| Message ID | 20200122001822.12872-2-fernando.pacheco@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [CI,1/2] drm/i915/guc: Provide mmio list to be saved/restored on engine reset | expand |
Quoting Fernando Pacheco (2020-01-22 00:18:22) > Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com> > --- > drivers/gpu/drm/i915/i915_params.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index 947d0a38fa3c..4d17235c33bd 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -56,7 +56,7 @@ struct drm_printer; > param(int, disable_power_well, -1, 0400) \ > param(int, enable_ips, 1, 0600) \ > param(int, invert_brightness, 0, 0600) \ > - param(int, enable_guc, 0, 0400) \ > + param(int, enable_guc, 2, 0400) \ > param(int, guc_log_level, -1, 0400) \ > param(char *, guc_firmware_path, NULL, 0400) \ > param(char *, huc_firmware_path, NULL, 0400) \ intel_guc_reset_engine() is only used in guc submission mode. This tests nothing. -Chris
On 1/22/20 4:52 AM, Chris Wilson wrote: > Quoting Fernando Pacheco (2020-01-22 00:18:22) >> Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com> >> --- >> drivers/gpu/drm/i915/i915_params.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h >> index 947d0a38fa3c..4d17235c33bd 100644 >> --- a/drivers/gpu/drm/i915/i915_params.h >> +++ b/drivers/gpu/drm/i915/i915_params.h >> @@ -56,7 +56,7 @@ struct drm_printer; >> param(int, disable_power_well, -1, 0400) \ >> param(int, enable_ips, 1, 0600) \ >> param(int, invert_brightness, 0, 0600) \ >> - param(int, enable_guc, 0, 0400) \ >> + param(int, enable_guc, 2, 0400) \ >> param(int, guc_log_level, -1, 0400) \ >> param(char *, guc_firmware_path, NULL, 0400) \ >> param(char *, huc_firmware_path, NULL, 0400) \ > intel_guc_reset_engine() is only used in guc submission mode. This tests > nothing. The mmio list is only important when GuC owns the engine reset (new interface). Just want to see here that the mmio list is constructed and formatted correctly when we hand the info off via the ADS. The reset flow will be fully tested during the push to turn submission on and the contents of the list can/will be tweaked as part of that validation. Fernando > -Chris
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 947d0a38fa3c..4d17235c33bd 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -56,7 +56,7 @@ struct drm_printer; param(int, disable_power_well, -1, 0400) \ param(int, enable_ips, 1, 0600) \ param(int, invert_brightness, 0, 0600) \ - param(int, enable_guc, 0, 0400) \ + param(int, enable_guc, 2, 0400) \ param(int, guc_log_level, -1, 0400) \ param(char *, guc_firmware_path, NULL, 0400) \ param(char *, huc_firmware_path, NULL, 0400) \
Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com> --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)