| Message ID | 20200122104009.15622-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer() | expand |
On 22/01/2020 12:40, Peter Ujfalusi wrote: > msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for > wait_for_completion_timeout() is also 'unsigned long' > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Reviewed-by: Tero Kristo <t-kristo@ti.com> > --- > drivers/firmware/ti_sci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 3d8241cb6921..361a82817c1f 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -422,7 +422,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info, > struct ti_sci_xfer *xfer) > { > int ret; > - int timeout; > + unsigned long timeout; > struct device *dev = info->dev; > > ret = mbox_send_message(info->chan_tx, &xfer->tx_message); > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Peter, On 2/3/20 12:38 AM, Tero Kristo wrote: > On 22/01/2020 12:40, Peter Ujfalusi wrote: >> msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for >> wait_for_completion_timeout() is also 'unsigned long' >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Reviewed-by: Tero Kristo <t-kristo@ti.com> > Can you collate all 3 patches in a series and repost with Tero's ack ? I will add that to next merge window queue. Regards, Santosh
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 3d8241cb6921..361a82817c1f 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -422,7 +422,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info, struct ti_sci_xfer *xfer) { int ret; - int timeout; + unsigned long timeout; struct device *dev = info->dev; ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
msecs_to_jiffies() returns 'unsigned long' and the timeout parameter for wait_for_completion_timeout() is also 'unsigned long' Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)