dt-binding: fix compilation error of the example in qcom,gcc.yaml
diff mbox series

Message ID 20200122134639.11735-1-dafna.hirschfeld@collabora.com
State Accepted
Commit 957d100926b4dbdd9a67b3de5065bfafbe4ac19f
Headers show
Series
  • dt-binding: fix compilation error of the example in qcom,gcc.yaml
Related show

Commit Message

Dafna Hirschfeld Jan. 22, 2020, 1:46 p.m. UTC
Running `make dt_binging_check`, gives the error:

DTC     Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
FATAL ERROR: Unable to parse input tree

This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
is defined in qcom,rpmcc.h but the include of this header is missing.
Add the include to fix the error.

Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
 Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Jan. 23, 2020, 2:25 p.m. UTC | #1
On Wed, Jan 22, 2020 at 7:46 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC     Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>

Fixes: d109ea0970cf ("dt-bindings: clock: Document external clocks for
MSM8998 gcc")
Acked-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 19d00794fe7d..50ff07f80acb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -220,6 +220,7 @@ examples:
>
>    # Example of MSM8998 GCC:
>    - |
> +    #include <dt-bindings/clock/qcom,rpmcc.h>
>      clock-controller@100000 {
>        compatible = "qcom,gcc-msm8998";
>        #clock-cells = <1>;
> --
> 2.17.1
>
Stephen Boyd Jan. 28, 2020, 6:26 p.m. UTC | #2
Quoting Dafna Hirschfeld (2020-01-22 05:46:39)
> Running `make dt_binging_check`, gives the error:
> 
> DTC     Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---

Applied to clk-next

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
index 19d00794fe7d..50ff07f80acb 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
@@ -220,6 +220,7 @@  examples:
 
   # Example of MSM8998 GCC:
   - |
+    #include <dt-bindings/clock/qcom,rpmcc.h>
     clock-controller@100000 {
       compatible = "qcom,gcc-msm8998";
       #clock-cells = <1>;