padata.h: Annotate parallel_data with __rcu
diff mbox series

Message ID 20200122170246.20177-1-madhuparnabhowmik10@gmail.com
State Not Applicable
Delegated to: Herbert Xu
Headers show
Series
  • padata.h: Annotate parallel_data with __rcu
Related show

Commit Message

Madhuparna Bhowmik Jan. 22, 2020, 5:02 p.m. UTC
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

This patch fixes the following sparse errors:
kernel/padata.c:110:14: error: incompatible types in comparison expression
kernel/padata.c:520:9: error: incompatible types in comparison expression
kernel/padata.c:1000:9: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
 include/linux/padata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Jordan Jan. 23, 2020, 4:08 p.m. UTC | #1
[add Herbert]

Hi Madhuparna,

On Wed, Jan 22, 2020 at 10:32:46PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> 
> This patch fixes the following sparse errors:
> kernel/padata.c:110:14: error: incompatible types in comparison expression
> kernel/padata.c:520:9: error: incompatible types in comparison expression
> kernel/padata.c:1000:9: error: incompatible types in comparison expression

This recent patch to padata in the cryptodev tree has fixed these sparse errors
and is heading for mainline soon:

https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=bbefa1dd6a6d53537c11624752219e39959d04fb

Thanks,
Daniel
Madhuparna Bhowmik Jan. 24, 2020, 4:26 a.m. UTC | #2
On Thu, Jan 23, 2020 at 11:08:50AM -0500, Daniel Jordan wrote:
> [add Herbert]
> 
> Hi Madhuparna,
> 
> On Wed, Jan 22, 2020 at 10:32:46PM +0530, madhuparnabhowmik10@gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > 
> > This patch fixes the following sparse errors:
> > kernel/padata.c:110:14: error: incompatible types in comparison expression
> > kernel/padata.c:520:9: error: incompatible types in comparison expression
> > kernel/padata.c:1000:9: error: incompatible types in comparison expression
> 
> This recent patch to padata in the cryptodev tree has fixed these sparse errors
> and is heading for mainline soon:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=bbefa1dd6a6d53537c11624752219e39959d04fb
>
Thank you for letting me know about this.

Regards,
Madhuparna

> Thanks,
> Daniel

Patch
diff mbox series

diff --git a/include/linux/padata.h b/include/linux/padata.h
index 23717eeaad23..72a081dd2b73 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -143,7 +143,7 @@  struct padata_instance {
 	struct hlist_node		 node;
 	struct workqueue_struct		*parallel_wq;
 	struct workqueue_struct		*serial_wq;
-	struct parallel_data		*pd;
+	struct parallel_data __rcu		*pd;
 	struct padata_cpumask		cpumask;
 	struct blocking_notifier_head	 cpumask_change_notifier;
 	struct kobject                   kobj;