xfs: fix uninitialized variable in xfs_attr3_leaf_inactive
diff mbox series

Message ID 20200123155552.GV8247@magnolia
State Accepted
Headers show
Series
  • xfs: fix uninitialized variable in xfs_attr3_leaf_inactive
Related show

Commit Message

Darrick J. Wong Jan. 23, 2020, 3:55 p.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Dan Carpenter pointed out that error is uninitialized.  While there
never should be an attr leaf block with zero entries, let's not leave
that logic bomb there.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_attr_inactive.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Allison Collins Jan. 23, 2020, 4:36 p.m. UTC | #1
On 1/23/20 8:55 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Dan Carpenter pointed out that error is uninitialized.  While there
> never should be an attr leaf block with zero entries, let's not leave
> that logic bomb there.
> 
Looks fine to me.
Reviewed-by: Allison Collins <allison.henderson@oracle.com>

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   fs/xfs/xfs_attr_inactive.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_inactive.c b/fs/xfs/xfs_attr_inactive.c
> index eddd5d311b0c..bbfa6ba84dcd 100644
> --- a/fs/xfs/xfs_attr_inactive.c
> +++ b/fs/xfs/xfs_attr_inactive.c
> @@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(
>   	struct xfs_attr_leafblock	*leaf = bp->b_addr;
>   	struct xfs_attr_leaf_entry	*entry;
>   	struct xfs_attr_leaf_name_remote *name_rmt;
> -	int				error;
> +	int				error = 0;
>   	int				i;
>   
>   	xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);
>
Eric Sandeen Jan. 23, 2020, 10:23 p.m. UTC | #2
On 1/23/20 9:55 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Dan Carpenter pointed out that error is uninitialized.  While there
> never should be an attr leaf block with zero entries, let's not leave
> that logic bomb there.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Fixes: 0bb9d159bd01 ("xfs: streamline xfs_attr3_leaf_inactive")
Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/xfs/xfs_attr_inactive.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_inactive.c b/fs/xfs/xfs_attr_inactive.c
> index eddd5d311b0c..bbfa6ba84dcd 100644
> --- a/fs/xfs/xfs_attr_inactive.c
> +++ b/fs/xfs/xfs_attr_inactive.c
> @@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(
>  	struct xfs_attr_leafblock	*leaf = bp->b_addr;
>  	struct xfs_attr_leaf_entry	*entry;
>  	struct xfs_attr_leaf_name_remote *name_rmt;
> -	int				error;
> +	int				error = 0;
>  	int				i;
>  
>  	xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);
>

Patch
diff mbox series

diff --git a/fs/xfs/xfs_attr_inactive.c b/fs/xfs/xfs_attr_inactive.c
index eddd5d311b0c..bbfa6ba84dcd 100644
--- a/fs/xfs/xfs_attr_inactive.c
+++ b/fs/xfs/xfs_attr_inactive.c
@@ -89,7 +89,7 @@  xfs_attr3_leaf_inactive(
 	struct xfs_attr_leafblock	*leaf = bp->b_addr;
 	struct xfs_attr_leaf_entry	*entry;
 	struct xfs_attr_leaf_name_remote *name_rmt;
-	int				error;
+	int				error = 0;
 	int				i;
 
 	xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);