Message ID | 1579787449-27599-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, 23 Jan 2020 at 16:45, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000) > > are available in the git repository at: > > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to f7bb7a3f1e8f4f854208785eead0d807ad8a688c: > > tests: fix test-qga on macosx (2020-01-23 14:34:49 +0100) > > ---------------------------------------------------------------- > * Register qdev properties as class properties (Marc-André) > * Cleanups (Philippe) > * virtio-scsi fix (Pan Nengyuan) > * Tweak Skylake-v3 model id (Kashyap) > * x86 UCODE_REV support and nested live migration fix (myself) > * Advisory mode for pvpanic (Zhenwei) > > ---------------------------------------------------------------- When I try to build-test this merge, the clang sanitizer build seems to fail whenever it tries to link anything: (configure args '--cc=clang' '--cxx=clang++' '--enable-gtk' '--extra-cflags=-fsanitize=undefined -fno-sanitize=shift-base -Werror') LINK tests/qemu-iotests/socket_scm_helper tests/qemu-iotests/socket_scm_helper.o: In function `send_fd': /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:53: undefined reference to `__ubsan_handle_type_mismatch_v1' tests/qemu-iotests/socket_scm_helper.o: In function `main': /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:111: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:116: undefined reference to `__ubsan_handle_type_mismatch_v1' tests/qemu-iotests/socket_scm_helper.o: In function `send_fd': /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:56: undefined reference to `__ubsan_handle_type_mismatch_v1' tests/qemu-iotests/socket_scm_helper.o: In function `main': /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:121: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:121: undefined reference to `__ubsan_handle_nonnull_arg' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:106: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:123: undefined reference to `__ubsan_handle_type_mismatch_v1' tests/qemu-iotests/socket_scm_helper.o: In function `get_fd_num': /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:68: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:69: undefined reference to `__ubsan_handle_nonnull_arg' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:70: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:77: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:77: undefined reference to `__ubsan_handle_type_mismatch_v1' /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:73: undefined reference to `__ubsan_handle_type_mismatch_v1' clang: error: linker command failed with exit code 1 (use -v to see invocation) I suspect the configure patches that try to clean up cflags are the cause here. thanks -- PMM
Il gio 23 gen 2020, 19:43 Peter Maydell <peter.maydell@linaro.org> ha scritto: > On Thu, 23 Jan 2020 at 16:45, Paolo Bonzini <pbonzini@redhat.com> wrote: > > > > The following changes since commit > 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 > 15:29:25 +0000) > > > > are available in the git repository at: > > > > > > git://github.com/bonzini/qemu.git tags/for-upstream > > > > for you to fetch changes up to f7bb7a3f1e8f4f854208785eead0d807ad8a688c: > > > > tests: fix test-qga on macosx (2020-01-23 14:34:49 +0100) > > > > ---------------------------------------------------------------- > > * Register qdev properties as class properties (Marc-André) > > * Cleanups (Philippe) > > * virtio-scsi fix (Pan Nengyuan) > > * Tweak Skylake-v3 model id (Kashyap) > > * x86 UCODE_REV support and nested live migration fix (myself) > > * Advisory mode for pvpanic (Zhenwei) > > > > ---------------------------------------------------------------- > > When I try to build-test this merge, the clang sanitizer > build seems to fail whenever it tries to link anything: > (configure args '--cc=clang' '--cxx=clang++' '--enable-gtk' > '--extra-cflags=-fsanitize=undefined -fno-sanitize=shift-base -Werror') > That's intended, you need to add -fsanitize=undefined to --extra-ldflags as well now. I can change that back, but then I am not sure what one would use --extra-ldflags for. Paolo > LINK tests/qemu-iotests/socket_scm_helper > tests/qemu-iotests/socket_scm_helper.o: In function `send_fd': > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:53: > undefined reference to `__ubsan_handle_type_mismatch_v1' > tests/qemu-iotests/socket_scm_helper.o: In function `main': > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:111: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:116: > undefined reference to `__ubsan_handle_type_mismatch_v1' > tests/qemu-iotests/socket_scm_helper.o: In function `send_fd': > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:56: > undefined reference to `__ubsan_handle_type_mismatch_v1' > tests/qemu-iotests/socket_scm_helper.o: In function `main': > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:121: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:121: > undefined reference to `__ubsan_handle_nonnull_arg' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:106: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:123: > undefined reference to `__ubsan_handle_type_mismatch_v1' > tests/qemu-iotests/socket_scm_helper.o: In function `get_fd_num': > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:68: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:69: > undefined reference to `__ubsan_handle_nonnull_arg' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:70: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:77: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:77: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/socket_scm_helper.c:73: > undefined reference to `__ubsan_handle_type_mismatch_v1' > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > I suspect the configure patches that try to clean up cflags > are the cause here. > > thanks > -- PMM > >
On 1/23/20 9:20 AM, Paolo Bonzini wrote: > Il gio 23 gen 2020, 19:43 Peter Maydell <peter.maydell@linaro.org > <mailto:peter.maydell@linaro.org>> ha scritto: > When I try to build-test this merge, the clang sanitizer > build seems to fail whenever it tries to link anything: > (configure args '--cc=clang' '--cxx=clang++' '--enable-gtk' > '--extra-cflags=-fsanitize=undefined -fno-sanitize=shift-base -Werror') > > > That's intended, you need to add -fsanitize=undefined to --extra-ldflags as > well now. I can change that back, but then I am not sure what one would use > --extra-ldflags for. This seems broken to me. Most cflags have to be present on the link line as well, unless you know very much what you're doing. I would not expect --extra-cflags to have to be repeated. r~
On 24/01/20 00:31, Richard Henderson wrote: > On 1/23/20 9:20 AM, Paolo Bonzini wrote: >> Il gio 23 gen 2020, 19:43 Peter Maydell <peter.maydell@linaro.org >> <mailto:peter.maydell@linaro.org>> ha scritto: >> When I try to build-test this merge, the clang sanitizer >> build seems to fail whenever it tries to link anything: >> (configure args '--cc=clang' '--cxx=clang++' '--enable-gtk' >> '--extra-cflags=-fsanitize=undefined -fno-sanitize=shift-base -Werror') >> >> >> That's intended, you need to add -fsanitize=undefined to --extra-ldflags as >> well now. I can change that back, but then I am not sure what one would use >> --extra-ldflags for. > > This seems broken to me. Most cflags have to be present on the link line as > well, unless you know very much what you're doing. I would not expect > --extra-cflags to have to be repeated. But then Peter's command line is missing --extra-cxxflags. So I think more clarity is better even at the cost of verbosity. Anyway, for now I'll make --extra-cflags affect both EXTRA_CFLAGS and EXTRA_LDFLAGS. Paolo