xfs: remove unnecessary variable
diff mbox series

Message ID 20200124052210.GV8257@magnolia
State New
Headers show
Series
  • xfs: remove unnecessary variable
Related show

Commit Message

Darrick J. Wong Jan. 24, 2020, 5:22 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Stephen Rothwell reported an unused variable.  Remove it.

Fixes: 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_inode.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Darrick J. Wong Jan. 24, 2020, 5:24 a.m. UTC | #1
On Thu, Jan 23, 2020 at 09:22:10PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Stephen Rothwell reported an unused variable.  Remove it.
> 
> Fixes: 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

self NAK, YueHaibing already sent this, which going through bash history
I evidently misapplied and ... yeah.  I've lost my marbles. :(

--D

> ---
>  fs/xfs/xfs_inode.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 1309f25c0d2b..1979a0055763 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags(
>  	xfs_fileoff_t		first_unmap_block;
>  	xfs_filblks_t		unmap_len;
>  	int			error = 0;
> -	int			done = 0;
>  
>  	ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
>  	ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||

Patch
diff mbox series

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 1309f25c0d2b..1979a0055763 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1520,7 +1520,6 @@  xfs_itruncate_extents_flags(
 	xfs_fileoff_t		first_unmap_block;
 	xfs_filblks_t		unmap_len;
 	int			error = 0;
-	int			done = 0;
 
 	ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
 	ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||