drm/i915: Stub out i915_gpu_coredump_put
diff mbox series

Message ID 20200124192255.541355-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915: Stub out i915_gpu_coredump_put
Related show

Commit Message

Chris Wilson Jan. 24, 2020, 7:22 p.m. UTC
i915_gpu_coreddump_put is currently only defined if
CONFIG_DRM_I915_CAPTURE_ERROR is enabled, provide a stub otherwise.

Reported-by: Mike Lothian <mike@fireburn.co.uk>
Fixes: 742379c0c400 ("drm/i915: Start chopping up the GPU error capture")
Fixes: 748317386afb ("drm/i915/execlists: Offline error capture")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mike Lothian <mike@fireburn.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andi Shyti Jan. 27, 2020, 11:27 a.m. UTC | #1
Hi Chris,

On Fri, Jan 24, 2020 at 07:22:55PM +0000, Chris Wilson wrote:
> i915_gpu_coreddump_put is currently only defined if
> CONFIG_DRM_I915_CAPTURE_ERROR is enabled, provide a stub otherwise.
> 
> Reported-by: Mike Lothian <mike@fireburn.co.uk>
> Fixes: 742379c0c400 ("drm/i915: Start chopping up the GPU error capture")
> Fixes: 748317386afb ("drm/i915/execlists: Offline error capture")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mike Lothian <mike@fireburn.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>

right!

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
index 41c1475e1500..e4a6afed3bbf 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.h
+++ b/drivers/gpu/drm/i915/i915_gpu_error.h
@@ -318,6 +318,10 @@  i915_error_state_store(struct i915_gpu_coredump *error)
 {
 }
 
+static inline void i915_gpu_coredump_put(struct i915_gpu_coredump *gpu)
+{
+}
+
 static inline struct i915_gpu_coredump *
 i915_first_error_state(struct drm_i915_private *i915)
 {