[CI] drm/i915/dp: Modeset only the tiled connectors with CRTC
diff mbox series

Message ID 20200124235440.15974-1-manasi.d.navare@intel.com
State New
Headers show
Series
  • [CI] drm/i915/dp: Modeset only the tiled connectors with CRTC
Related show

Commit Message

Manasi Navare Jan. 24, 2020, 11:54 p.m. UTC
In case of tiled connectors if one of the tiled connectors in state
needs a full modeset we add other tiled connectors to the state. Make sure
that the connector has a CRTC before forcing a modeset on that else it fails
committing the state.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/516
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Manasi Navare Jan. 25, 2020, 2:19 a.m. UTC | #1
This Gem related failure is not relevant to this patch, but because of this it doesn’t run full IGT, I want to make sure that the kms_flip tests are not getting hung.

Or can we confirm this with manual testing?

Manasi

-----Original Message-----
From: Patchwork <patchwork@emeril.freedesktop.org> 
Sent: Friday, January 24, 2020 5:47 PM
To: Navare, Manasi D <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors with CRTC

== Series Details ==

Series: drm/i915/dp: Modeset only the tiled connectors with CRTC
URL   : https://patchwork.freedesktop.org/series/72559/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7811 -> Patchwork_16267 ====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_16267 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_16267, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_16267:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_close_race@basic-threads:
    - fi-hsw-peppy:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-peppy/igt@gem_close_race@basic-threads.html

  
Known issues
------------

  Here are the changes found in Patchwork_16267 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@fds:
    - fi-byt-n2820:       [TIMEOUT][5] ([fdo#112271]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-n2820/igt@gem_exec_parallel@fds.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-n2820/igt@gem_exec_parallel@fds.html

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-cfl-8700k:       [DMESG-WARN][7] ([i915#889]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_gtt:
    - fi-bdw-5557u:       [TIMEOUT][13] ([fdo#112271]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-bdw-5557u/igt@i915_selftest@live_gtt.html

  
#### Warnings ####

  * igt@gem_exec_parallel@contexts:
    - fi-byt-n2820:       [FAIL][15] ([i915#694]) -> [TIMEOUT][16] ([fdo#112271])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-n2820/igt@gem_exec_parallel@contexts.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-icl-u2:          [FAIL][17] ([i915#217]) -> [DMESG-WARN][18] ([IGT#4] / [i915#263])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html

  
  [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889


Participating hosts (47 -> 42)
------------------------------

  Additional (1): fi-skl-6600u 
  Missing    (6): fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7811 -> Patchwork_16267

  CI-20190529: 20190529
  CI_DRM_7811: f528982f5c837f075e82ca544df010ca5183064a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5384: fd6896567f7d612c76207970376d4f1e634ded55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_16267: bb6a759231f414d531349ca24cca365f50dedaca @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

bb6a759231f4 drm/i915/dp: Modeset only the tiled connectors with CRTC

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/index.html
Saarinen, Jani Jan. 25, 2020, 9:31 a.m. UTC | #2
+ Martin to re-report. 

> -----Original Message-----
> From: Navare, Manasi D <manasi.d.navare@intel.com>
> Sent: lauantai 25. tammikuuta 2020 4.19
> To: intel-gfx@lists.freedesktop.org
> Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Saarinen, Jani
> <jani.saarinen@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>;
> Nikkanen, Kimmo <kimmo.nikkanen@intel.com>
> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
> with CRTC
> 
> This Gem related failure is not relevant to this patch, but because of this it doesn’t
> run full IGT, I want to make sure that the kms_flip tests are not getting hung.
> 
> Or can we confirm this with manual testing?
> 
> Manasi
> 
> -----Original Message-----
> From: Patchwork <patchwork@emeril.freedesktop.org>
> Sent: Friday, January 24, 2020 5:47 PM
> To: Navare, Manasi D <manasi.d.navare@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
> with CRTC
> 
> == Series Details ==
> 
> Series: drm/i915/dp: Modeset only the tiled connectors with CRTC
> URL   : https://patchwork.freedesktop.org/series/72559/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7811 -> Patchwork_16267
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_16267 absolutely need to be
>   verified manually.
> 
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_16267, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_16267/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_16267:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_close_race@basic-threads:
>     - fi-hsw-peppy:       [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
> peppy/igt@gem_close_race@basic-threads.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
> peppy/igt@gem_close_race@basic-threads.html
> 
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_16267 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@kms_chamelium@hdmi-hpd-fast:
>     - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-kbl-
> 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-kbl-
> 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> 
> 
> #### Possible fixes ####
> 
>   * igt@gem_exec_parallel@fds:
>     - fi-byt-n2820:       [TIMEOUT][5] ([fdo#112271]) -> [PASS][6]
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> n2820/igt@gem_exec_parallel@fds.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> n2820/igt@gem_exec_parallel@fds.html
> 
>   * igt@i915_module_load@reload-with-fault-injection:
>     - fi-cfl-8700k:       [DMESG-WARN][7] ([i915#889]) -> [PASS][8]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-cfl-
> 8700k/igt@i915_module_load@reload-with-fault-injection.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-cfl-
> 8700k/igt@i915_module_load@reload-with-fault-injection.html
> 
>   * igt@i915_selftest@live_blt:
>     - fi-hsw-4770:        [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
> 4770/igt@i915_selftest@live_blt.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
> 4770/igt@i915_selftest@live_blt.html
> 
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-byt-n2820:       [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> n2820/igt@i915_selftest@live_gem_contexts.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> n2820/igt@i915_selftest@live_gem_contexts.html
> 
>   * igt@i915_selftest@live_gtt:
>     - fi-bdw-5557u:       [TIMEOUT][13] ([fdo#112271]) -> [PASS][14]
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-bdw-
> 5557u/igt@i915_selftest@live_gtt.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-bdw-
> 5557u/igt@i915_selftest@live_gtt.html
> 
> 
> #### Warnings ####
> 
>   * igt@gem_exec_parallel@contexts:
>     - fi-byt-n2820:       [FAIL][15] ([i915#694]) -> [TIMEOUT][16] ([fdo#112271])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> n2820/igt@gem_exec_parallel@contexts.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> n2820/igt@gem_exec_parallel@contexts.html
> 
>   * igt@kms_chamelium@common-hpd-after-suspend:
>     - fi-icl-u2:          [FAIL][17] ([i915#217]) -> [DMESG-WARN][18] ([IGT#4] /
> [i915#263])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-icl-
> u2/igt@kms_chamelium@common-hpd-after-suspend.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-icl-
> u2/igt@kms_chamelium@common-hpd-after-suspend.html
> 
> 
>   [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
>   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
>   [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
>   [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
>   [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
>   [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
>   [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
>   [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
>   [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
>   [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
> 
> 
> Participating hosts (47 -> 42)
> ------------------------------
> 
>   Additional (1): fi-skl-6600u
>   Missing    (6): fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
> fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7811 -> Patchwork_16267
> 
>   CI-20190529: 20190529
>   CI_DRM_7811: f528982f5c837f075e82ca544df010ca5183064a @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5384: fd6896567f7d612c76207970376d4f1e634ded55 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_16267: bb6a759231f414d531349ca24cca365f50dedaca @
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> bb6a759231f4 drm/i915/dp: Modeset only the tiled connectors with CRTC
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_16267/index.html
Manasi Navare Jan. 27, 2020, 11:06 p.m. UTC | #3
On Sat, Jan 25, 2020 at 01:31:06AM -0800, Saarinen, Jani wrote:
> + Martin to re-report.

Could you re-report this so we get the full CI IGT results?

Manasi
 
> 
> > -----Original Message-----
> > From: Navare, Manasi D <manasi.d.navare@intel.com>
> > Sent: lauantai 25. tammikuuta 2020 4.19
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Saarinen, Jani
> > <jani.saarinen@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>;
> > Nikkanen, Kimmo <kimmo.nikkanen@intel.com>
> > Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
> > with CRTC
> > 
> > This Gem related failure is not relevant to this patch, but because of this it doesn’t
> > run full IGT, I want to make sure that the kms_flip tests are not getting hung.
> > 
> > Or can we confirm this with manual testing?
> > 
> > Manasi
> > 
> > -----Original Message-----
> > From: Patchwork <patchwork@emeril.freedesktop.org>
> > Sent: Friday, January 24, 2020 5:47 PM
> > To: Navare, Manasi D <manasi.d.navare@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
> > with CRTC
> > 
> > == Series Details ==
> > 
> > Series: drm/i915/dp: Modeset only the tiled connectors with CRTC
> > URL   : https://patchwork.freedesktop.org/series/72559/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7811 -> Patchwork_16267
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_16267 absolutely need to be
> >   verified manually.
> > 
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_16267, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_16267/index.html
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in
> > Patchwork_16267:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@gem_close_race@basic-threads:
> >     - fi-hsw-peppy:       [PASS][1] -> [INCOMPLETE][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
> > peppy/igt@gem_close_race@basic-threads.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
> > peppy/igt@gem_close_race@basic-threads.html
> > 
> > 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_16267 that come from known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@kms_chamelium@hdmi-hpd-fast:
> >     - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-kbl-
> > 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-kbl-
> > 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> > 
> > 
> > #### Possible fixes ####
> > 
> >   * igt@gem_exec_parallel@fds:
> >     - fi-byt-n2820:       [TIMEOUT][5] ([fdo#112271]) -> [PASS][6]
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> > n2820/igt@gem_exec_parallel@fds.html
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> > n2820/igt@gem_exec_parallel@fds.html
> > 
> >   * igt@i915_module_load@reload-with-fault-injection:
> >     - fi-cfl-8700k:       [DMESG-WARN][7] ([i915#889]) -> [PASS][8]
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-cfl-
> > 8700k/igt@i915_module_load@reload-with-fault-injection.html
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-cfl-
> > 8700k/igt@i915_module_load@reload-with-fault-injection.html
> > 
> >   * igt@i915_selftest@live_blt:
> >     - fi-hsw-4770:        [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
> > 4770/igt@i915_selftest@live_blt.html
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
> > 4770/igt@i915_selftest@live_blt.html
> > 
> >   * igt@i915_selftest@live_gem_contexts:
> >     - fi-byt-n2820:       [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> > n2820/igt@i915_selftest@live_gem_contexts.html
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> > n2820/igt@i915_selftest@live_gem_contexts.html
> > 
> >   * igt@i915_selftest@live_gtt:
> >     - fi-bdw-5557u:       [TIMEOUT][13] ([fdo#112271]) -> [PASS][14]
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-bdw-
> > 5557u/igt@i915_selftest@live_gtt.html
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-bdw-
> > 5557u/igt@i915_selftest@live_gtt.html
> > 
> > 
> > #### Warnings ####
> > 
> >   * igt@gem_exec_parallel@contexts:
> >     - fi-byt-n2820:       [FAIL][15] ([i915#694]) -> [TIMEOUT][16] ([fdo#112271])
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
> > n2820/igt@gem_exec_parallel@contexts.html
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
> > n2820/igt@gem_exec_parallel@contexts.html
> > 
> >   * igt@kms_chamelium@common-hpd-after-suspend:
> >     - fi-icl-u2:          [FAIL][17] ([i915#217]) -> [DMESG-WARN][18] ([IGT#4] /
> > [i915#263])
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-icl-
> > u2/igt@kms_chamelium@common-hpd-after-suspend.html
> >    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-icl-
> > u2/igt@kms_chamelium@common-hpd-after-suspend.html
> > 
> > 
> >   [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
> >   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
> >   [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
> >   [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
> >   [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
> >   [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
> >   [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
> >   [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
> >   [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
> >   [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
> > 
> > 
> > Participating hosts (47 -> 42)
> > ------------------------------
> > 
> >   Additional (1): fi-skl-6600u
> >   Missing    (6): fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
> > fi-bdw-samus
> > 
> > 
> > Build changes
> > -------------
> > 
> >   * CI: CI-20190529 -> None
> >   * Linux: CI_DRM_7811 -> Patchwork_16267
> > 
> >   CI-20190529: 20190529
> >   CI_DRM_7811: f528982f5c837f075e82ca544df010ca5183064a @
> > git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_5384: fd6896567f7d612c76207970376d4f1e634ded55 @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_16267: bb6a759231f414d531349ca24cca365f50dedaca @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > 
> > 
> > == Linux commits ==
> > 
> > bb6a759231f4 drm/i915/dp: Modeset only the tiled connectors with CRTC
> > 
> > == Logs ==
> > 
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-
> > tip/Patchwork_16267/index.html
Peres, Martin Jan. 28, 2020, 7:50 a.m. UTC | #4
On 28/01/2020 01:05, Navare, Manasi D wrote:
> On Sat, Jan 25, 2020 at 01:31:06AM -0800, Saarinen, Jani wrote:
>> + Martin to re-report.
> 
> Could you re-report this so we get the full CI IGT results?

Sorry, I had done the work but I re-reported the wrong run...

Anyway, I queued the re-reporting. Sorry about this!

Martin

> 
> Manasi
>  
>>
>>> -----Original Message-----
>>> From: Navare, Manasi D <manasi.d.navare@intel.com>
>>> Sent: lauantai 25. tammikuuta 2020 4.19
>>> To: intel-gfx@lists.freedesktop.org
>>> Cc: Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Saarinen, Jani
>>> <jani.saarinen@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>;
>>> Nikkanen, Kimmo <kimmo.nikkanen@intel.com>
>>> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
>>> with CRTC
>>>
>>> This Gem related failure is not relevant to this patch, but because of this it doesn’t
>>> run full IGT, I want to make sure that the kms_flip tests are not getting hung.
>>>
>>> Or can we confirm this with manual testing?
>>>
>>> Manasi
>>>
>>> -----Original Message-----
>>> From: Patchwork <patchwork@emeril.freedesktop.org>
>>> Sent: Friday, January 24, 2020 5:47 PM
>>> To: Navare, Manasi D <manasi.d.navare@intel.com>
>>> Cc: intel-gfx@lists.freedesktop.org
>>> Subject: ✗ Fi.CI.BAT: failure for drm/i915/dp: Modeset only the tiled connectors
>>> with CRTC
>>>
>>> == Series Details ==
>>>
>>> Series: drm/i915/dp: Modeset only the tiled connectors with CRTC
>>> URL   : https://patchwork.freedesktop.org/series/72559/
>>> State : failure
>>>
>>> == Summary ==
>>>
>>> CI Bug Log - changes from CI_DRM_7811 -> Patchwork_16267
>>> ====================================================
>>>
>>> Summary
>>> -------
>>>
>>>   **FAILURE**
>>>
>>>   Serious unknown changes coming with Patchwork_16267 absolutely need to be
>>>   verified manually.
>>>
>>>   If you think the reported changes have nothing to do with the changes
>>>   introduced in Patchwork_16267, please notify your bug team to allow them
>>>   to document this new failure mode, which will reduce false positives in CI.
>>>
>>>   External URL: https://intel-gfx-ci.01.org/tree/drm-
>>> tip/Patchwork_16267/index.html
>>>
>>> Possible new issues
>>> -------------------
>>>
>>>   Here are the unknown changes that may have been introduced in
>>> Patchwork_16267:
>>>
>>> ### IGT changes ###
>>>
>>> #### Possible regressions ####
>>>
>>>   * igt@gem_close_race@basic-threads:
>>>     - fi-hsw-peppy:       [PASS][1] -> [INCOMPLETE][2]
>>>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
>>> peppy/igt@gem_close_race@basic-threads.html
>>>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
>>> peppy/igt@gem_close_race@basic-threads.html
>>>
>>>
>>> Known issues
>>> ------------
>>>
>>>   Here are the changes found in Patchwork_16267 that come from known issues:
>>>
>>> ### IGT changes ###
>>>
>>> #### Issues hit ####
>>>
>>>   * igt@kms_chamelium@hdmi-hpd-fast:
>>>     - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111096] / [i915#323])
>>>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-kbl-
>>> 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>>>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-kbl-
>>> 7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>>>
>>>
>>> #### Possible fixes ####
>>>
>>>   * igt@gem_exec_parallel@fds:
>>>     - fi-byt-n2820:       [TIMEOUT][5] ([fdo#112271]) -> [PASS][6]
>>>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
>>> n2820/igt@gem_exec_parallel@fds.html
>>>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
>>> n2820/igt@gem_exec_parallel@fds.html
>>>
>>>   * igt@i915_module_load@reload-with-fault-injection:
>>>     - fi-cfl-8700k:       [DMESG-WARN][7] ([i915#889]) -> [PASS][8]
>>>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-cfl-
>>> 8700k/igt@i915_module_load@reload-with-fault-injection.html
>>>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-cfl-
>>> 8700k/igt@i915_module_load@reload-with-fault-injection.html
>>>
>>>   * igt@i915_selftest@live_blt:
>>>     - fi-hsw-4770:        [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
>>>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-hsw-
>>> 4770/igt@i915_selftest@live_blt.html
>>>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-hsw-
>>> 4770/igt@i915_selftest@live_blt.html
>>>
>>>   * igt@i915_selftest@live_gem_contexts:
>>>     - fi-byt-n2820:       [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
>>>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
>>> n2820/igt@i915_selftest@live_gem_contexts.html
>>>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
>>> n2820/igt@i915_selftest@live_gem_contexts.html
>>>
>>>   * igt@i915_selftest@live_gtt:
>>>     - fi-bdw-5557u:       [TIMEOUT][13] ([fdo#112271]) -> [PASS][14]
>>>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-bdw-
>>> 5557u/igt@i915_selftest@live_gtt.html
>>>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-bdw-
>>> 5557u/igt@i915_selftest@live_gtt.html
>>>
>>>
>>> #### Warnings ####
>>>
>>>   * igt@gem_exec_parallel@contexts:
>>>     - fi-byt-n2820:       [FAIL][15] ([i915#694]) -> [TIMEOUT][16] ([fdo#112271])
>>>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-byt-
>>> n2820/igt@gem_exec_parallel@contexts.html
>>>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-byt-
>>> n2820/igt@gem_exec_parallel@contexts.html
>>>
>>>   * igt@kms_chamelium@common-hpd-after-suspend:
>>>     - fi-icl-u2:          [FAIL][17] ([i915#217]) -> [DMESG-WARN][18] ([IGT#4] /
>>> [i915#263])
>>>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7811/fi-icl-
>>> u2/igt@kms_chamelium@common-hpd-after-suspend.html
>>>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16267/fi-icl-
>>> u2/igt@kms_chamelium@common-hpd-after-suspend.html
>>>
>>>
>>>   [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
>>>   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
>>>   [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
>>>   [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
>>>   [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
>>>   [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
>>>   [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
>>>   [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
>>>   [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
>>>   [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
>>>
>>>
>>> Participating hosts (47 -> 42)
>>> ------------------------------
>>>
>>>   Additional (1): fi-skl-6600u
>>>   Missing    (6): fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
>>> fi-bdw-samus
>>>
>>>
>>> Build changes
>>> -------------
>>>
>>>   * CI: CI-20190529 -> None
>>>   * Linux: CI_DRM_7811 -> Patchwork_16267
>>>
>>>   CI-20190529: 20190529
>>>   CI_DRM_7811: f528982f5c837f075e82ca544df010ca5183064a @
>>> git://anongit.freedesktop.org/gfx-ci/linux
>>>   IGT_5384: fd6896567f7d612c76207970376d4f1e634ded55 @
>>> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>>>   Patchwork_16267: bb6a759231f414d531349ca24cca365f50dedaca @
>>> git://anongit.freedesktop.org/gfx-ci/linux
>>>
>>>
>>> == Linux commits ==
>>>
>>> bb6a759231f4 drm/i915/dp: Modeset only the tiled connectors with CRTC
>>>
>>> == Logs ==
>>>
>>> For more details see: https://intel-gfx-ci.01.org/tree/drm-
>>> tip/Patchwork_16267/index.html
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 32c6940c9077..81addaea616b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -13155,11 +13155,12 @@  intel_modeset_pipe_config(struct intel_crtc_state *pipe_config)
 	}
 
 	/* Get total number of tiled connectors in state that belong to
-	 * this tile group.
+	 * this tile group and that have a CRTC
 	 */
 	for_each_new_connector_in_state(state, connector, connector_state, i) {
 		if (connector->has_tile &&
-		    connector->tile_group->id == tile_group_id)
+		    connector->tile_group->id == tile_group_id &&
+		    connector_state->crtc)
 			num_tiled_conns++;
 	}
 
@@ -14506,13 +14507,14 @@  intel_modeset_all_tiles(struct intel_atomic_state *state, int tile_grp_id)
 			continue;
 		conn_state = drm_atomic_get_connector_state(&state->base,
 							    connector);
+
 		if (IS_ERR(conn_state)) {
 			ret =  PTR_ERR(conn_state);
 			break;
 		}
 
 		if (!conn_state->crtc)
-			continue;
+			break;
 
 		crtc_state = drm_atomic_get_crtc_state(&state->base,
 						       conn_state->crtc);
@@ -14549,6 +14551,8 @@  intel_atomic_check_tiled_conns(struct intel_atomic_state *state)
 			continue;
 		if (!intel_connector_needs_modeset(state, connector))
 			continue;
+		if (!new_conn_state->crtc)
+			continue;
 
 		ret = intel_modeset_all_tiles(state, connector->tile_group->id);
 		if (ret)