ALSA: usb-audio: add quirks for Line6 Helix fw 2.82
diff mbox series

Message ID 20200125132226.31277-1-nick83ola@gmail.com
State New
Headers show
Series
  • ALSA: usb-audio: add quirks for Line6 Helix fw 2.82
Related show

Commit Message

Nicola Lunghi Jan. 25, 2020, 1:22 p.m. UTC
Line6 Helix fw 2.82 still needs a quirk to set the audio rate to 48khz but
in respect to older firmware has changed the USB ID of the device.

Add it to the quirk list for line6 helix family of devices.

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 sound/usb/format.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Jan. 25, 2020, 2:08 p.m. UTC | #1
On Sat, 25 Jan 2020 14:22:27 +0100,
Nicola Lunghi wrote:
> 
> Line6 Helix fw 2.82 still needs a quirk to set the audio rate to 48khz but
> in respect to older firmware has changed the USB ID of the device.
> 
> Add it to the quirk list for line6 helix family of devices.
> 
> Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>

Applied now.  Thanks.


Takashi
Jens Verwiebe Jan. 25, 2020, 2:12 p.m. UTC | #2
Hi

Why this incomplete patch ???

I longer informed you that with fw >= 2.8 lot of helix kind devices got 
a new ID:

So this patch should include at least the well known/collected data:

case USB_ID(0x0E41, 0x424a): /* Line6 Helix LT - firmware >= 2.8 */


Jens
Takashi Iwai Jan. 25, 2020, 2:16 p.m. UTC | #3
On Sat, 25 Jan 2020 15:12:48 +0100,
Jens Verwiebe wrote:
> 
> Hi
> 
> Why this incomplete patch ???
> 
> I longer informed you that with fw >= 2.8 lot of helix kind devices
> got a new ID:
> 
> So this patch should include at least the well known/collected data:
> 
> case USB_ID(0x0E41, 0x424a): /* Line6 Helix LT - firmware >= 2.8 */

Oh, so the patch doesn't work as is?
Then I drop it again.

If anyone can resubmit the comprehensive one and give the tested-by
tag, I'll happily apply it.


thanks,

Takashi
Nicola Lunghi Jan. 25, 2020, 2:34 p.m. UTC | #4
Hi Jens

On Sat, 25 Jan 2020 at 14:16, Takashi Iwai <tiwai@suse.de> wrote:
>
> On Sat, 25 Jan 2020 15:12:48 +0100,
> Jens Verwiebe wrote:
> >
> > Hi
> >
> > Why this incomplete patch ???
> >
> > I longer informed you that with fw >= 2.8 lot of helix kind devices
> > got a new ID:

Yes you told me but you didn't give me a list of the ID nor confirm
that you can test something.
The reason of this patch is that I created a post in the Line6 forum
when you told me that and the only user that
confirmed that the patch work with newer firmware with Helix is Carlo Calica.

I sadly have only access to an hx stomp and I don't want to put
patches that I cannot verify.

If you have access to other hardware instead of sending email to me
you should submit something yourself.

Cheers
Nicola Lunghi

> >
> > So this patch should include at least the well known/collected data:
> >
> > case USB_ID(0x0E41, 0x424a): /* Line6 Helix LT - firmware >= 2.8 */
>
> Oh, so the patch doesn't work as is?
> Then I drop it again.
>
> If anyone can resubmit the comprehensive one and give the tested-by
> tag, I'll happily apply it.
>
>
> thanks,
>
> Takashi
Alexander Tsoy Jan. 25, 2020, 2:35 p.m. UTC | #5
В Сб, 25/01/2020 в 15:16 +0100, Takashi Iwai пишет:
> On Sat, 25 Jan 2020 15:12:48 +0100,
> Jens Verwiebe wrote:
> > Hi
> > 
> > Why this incomplete patch ???
> > 
> > I longer informed you that with fw >= 2.8 lot of helix kind devices
> > got a new ID:
> > 
> > So this patch should include at least the well known/collected
> > data:
> > 
> > case USB_ID(0x0E41, 0x424a): /* Line6 Helix LT - firmware >= 2.8 */
> 
> Oh, so the patch doesn't work as is?
> Then I drop it again.
> 

No, Jens complained that the quirk should also be applied to other
devices from the Helix line that recieved new firmware. Not sure what's
the problem with submitting them in a follow-up patch.

> If anyone can resubmit the comprehensive one and give the tested-by
> tag, I'll happily apply it.
Jens Verwiebe Jan. 25, 2020, 2:38 p.m. UTC | #6
Kinda

Nicola made a request in the line6 forums and got at least helix lt 
confirmed.

As he took over my original patch + a fallback i want leave this to him to

maintain all new ( core ) ID's now.

Also i'd like to mention again that this "hardclocking" only makes helix 
devices

setup initially but does not prevent the sync shifting away after some time.

I was hoping the solution Mike Oliphant found for the Boss device would 
also fix the Helix sync,

but there is a bit more todo i fear. ( implicit feedback not working )

Still on that ....


Jens
Jens Verwiebe Jan. 25, 2020, 2:46 p.m. UTC | #7
Shall i show you the line6 forum entry where ppl confirmed ?

https://line6.com/support/topic/52539-need-linux-users-with-helix-helix-lt-helix-rack-helix-something/

Also my much older thread has info i gave you before:

https://line6.com/support/topic/4426-line-6-with-linux/#comments

So please don't miss that. The response from users is poor enough.


Jens

Patch
diff mbox series

diff --git a/sound/usb/format.c b/sound/usb/format.c
index d79db71305f6..e2b98f181d05 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -296,6 +296,7 @@  static int line6_parse_audio_format_rates_quirk(struct snd_usb_audio *chip,
 	case USB_ID(0x0E41, 0x4242): /* Line6 Helix Rack */
 	case USB_ID(0x0E41, 0x4244): /* Line6 Helix LT */
 	case USB_ID(0x0E41, 0x4246): /* Line6 HX-Stomp */
+	case USB_ID(0x0E41, 0x4248): /* Line6 Helix >= fw 2.82 */
 		/* supported rates: 48Khz */
 		kfree(fp->rate_table);
 		fp->rate_table = kmalloc(sizeof(int), GFP_KERNEL);