ALSA: hda: Add Clevo W65_67SB the power_save blacklist
diff mbox series

Message ID 20200125181021.70446-1-hdegoede@redhat.com
State New
Headers show
Series
  • ALSA: hda: Add Clevo W65_67SB the power_save blacklist
Related show

Commit Message

Hans de Goede Jan. 25, 2020, 6:10 p.m. UTC
Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
seconds of audio to be missing every time audio starts playing.

This commit adds the Clevo W65_67SB the power_save blacklist to avoid
this issue.

Cc: stable@vger.kernel.org
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sasha Levin Jan. 26, 2020, 1:38 a.m. UTC | #1
Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.4.14, v4.19.98, v4.14.167, v4.9.211, v4.4.211.

v5.4.14: Build OK!
v4.19.98: Build OK!
v4.14.167: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")

v4.9.211: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")

v4.4.211: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?
Takashi Iwai Jan. 26, 2020, 8:29 a.m. UTC | #2
On Sat, 25 Jan 2020 19:10:21 +0100,
Hans de Goede wrote:
> 
> Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
> seconds of audio to be missing every time audio starts playing.
> 
> This commit adds the Clevo W65_67SB the power_save blacklist to avoid
> this issue.
> 
> Cc: stable@vger.kernel.org
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thanks.


Takashi
Hans de Goede Jan. 26, 2020, 1:21 p.m. UTC | #3
Hi,

On 26-01-2020 02:38, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.4.14, v4.19.98, v4.14.167, v4.9.211, v4.4.211.
> 
> v5.4.14: Build OK!
> v4.19.98: Build OK!
> v4.14.167: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.9.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.4.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Just adding it to 4.19.98 and 5.4 (and 5.5) is fine.
Regards,

Hans

Patch
diff mbox series

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5b92f290cbb0..54d9ea1750f9 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2185,6 +2185,8 @@  static struct snd_pci_quirk power_save_blacklist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1581607 */
 	SND_PCI_QUIRK(0x1558, 0x3501, "Clevo W35xSS_370SS", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
+	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */