[1/5] xfsprogs: remove the ENABLE_GETTEXT substitution in platform_defs.h.in
diff mbox series

Message ID 20200126113541.787884-2-hch@lst.de
State Superseded
Headers show
Series
  • [1/5] xfsprogs: remove the ENABLE_GETTEXT substitution in platform_defs.h.in
Related show

Commit Message

Christoph Hellwig Jan. 26, 2020, 11:35 a.m. UTC
ENABLE_GETTEXT is already defined on the command line if enabled, no
need to duplicate it in platform_defs.h.in.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/platform_defs.h.in | 2 --
 1 file changed, 2 deletions(-)

Comments

Darrick J. Wong Jan. 26, 2020, 10:12 p.m. UTC | #1
On Sun, Jan 26, 2020 at 12:35:37PM +0100, Christoph Hellwig wrote:
> ENABLE_GETTEXT is already defined on the command line if enabled, no
> need to duplicate it in platform_defs.h.in.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Seems reasonable, though I wonder

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  include/platform_defs.h.in | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in
> index 1f7ceafb..6cc56e31 100644
> --- a/include/platform_defs.h.in
> +++ b/include/platform_defs.h.in
> @@ -36,8 +36,6 @@ typedef struct filldir		filldir_t;
>  typedef unsigned short umode_t;
>  #endif
>  
> -/* Define if you want gettext (I18N) support */
> -#undef ENABLE_GETTEXT
>  #ifdef ENABLE_GETTEXT
>  # include <libintl.h>
>  # define _(x)                   gettext(x)
> -- 
> 2.24.1
>

Patch
diff mbox series

diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in
index 1f7ceafb..6cc56e31 100644
--- a/include/platform_defs.h.in
+++ b/include/platform_defs.h.in
@@ -36,8 +36,6 @@  typedef struct filldir		filldir_t;
 typedef unsigned short umode_t;
 #endif
 
-/* Define if you want gettext (I18N) support */
-#undef ENABLE_GETTEXT
 #ifdef ENABLE_GETTEXT
 # include <libintl.h>
 # define _(x)                   gettext(x)