| Message ID | 20200127101343.20415-8-pragat.pandya@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: exfat: Fix checkpatch warning: Avoid | expand |
On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com> > --- > drivers/staging/exfat/exfat.h | 2 +- > drivers/staging/exfat/exfat_super.c | 16 ++++++++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h > index 85fbea44219a..5c207d715f44 100644 > --- a/drivers/staging/exfat/exfat.h > +++ b/drivers/staging/exfat/exfat.h > @@ -228,7 +228,7 @@ struct date_time_t { > u16 hour; > u16 minute; > u16 second; > - u16 MilliSecond; > + u16 milli_second; Normally we would just call it "ms". regards, dan carpenter
On Mon, Jan 27, 2020 at 02:55:31PM +0300, Dan Carpenter wrote: > On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > > > Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com> > > --- > > drivers/staging/exfat/exfat.h | 2 +- > > drivers/staging/exfat/exfat_super.c | 16 ++++++++-------- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h > > index 85fbea44219a..5c207d715f44 100644 > > --- a/drivers/staging/exfat/exfat.h > > +++ b/drivers/staging/exfat/exfat.h > > @@ -228,7 +228,7 @@ struct date_time_t { > > u16 hour; > > u16 minute; > > u16 second; > > - u16 MilliSecond; > > + u16 milli_second; > > Normally we would just call it "ms". Or millisecond, no "_" needed either way.
On Mon, 2020-01-27 at 14:55 +0300, Dan Carpenter wrote: > On Mon, Jan 27, 2020 at 03:43:28PM +0530, Pragat Pandya wrote: > > Change all the occurrences of "MilliSecond" to "milli_second" in exfat. > > > > Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com> > > --- > > drivers/staging/exfat/exfat.h | 2 +- > > drivers/staging/exfat/exfat_super.c | 16 ++++++++-------- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h > > index 85fbea44219a..5c207d715f44 100644 > > --- a/drivers/staging/exfat/exfat.h > > +++ b/drivers/staging/exfat/exfat.h > > @@ -228,7 +228,7 @@ struct date_time_t { > > u16 hour; > > u16 minute; > > u16 second; > > - u16 MilliSecond; > > + u16 milli_second; > > Normally we would just call it "ms". msec is a bit more common.
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 85fbea44219a..5c207d715f44 100644 --- a/drivers/staging/exfat/exfat.h +++ b/drivers/staging/exfat/exfat.h @@ -228,7 +228,7 @@ struct date_time_t { u16 hour; u16 minute; u16 second; - u16 MilliSecond; + u16 milli_second; }; struct part_info_t { diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 0582c49f091d..6cc21d795589 100644 --- a/drivers/staging/exfat/exfat_super.c +++ b/drivers/staging/exfat/exfat_super.c @@ -62,7 +62,7 @@ static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp) ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day, tp->hour, tp->minute, tp->second); - ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC; + ts->tv_nsec = tp->milli_second * NSEC_PER_MSEC; } /* Convert linear UNIX date to a FAT time/date pair. */ @@ -74,7 +74,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp) time64_to_tm(second, 0, &tm); if (second < UNIX_SECS_1980) { - tp->MilliSecond = 0; + tp->milli_second = 0; tp->second = 0; tp->minute = 0; tp->hour = 0; @@ -85,7 +85,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp) } if (second >= UNIX_SECS_2108) { - tp->MilliSecond = 999; + tp->milli_second = 999; tp->second = 59; tp->minute = 59; tp->hour = 23; @@ -95,7 +95,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp) return; } - tp->MilliSecond = ts->tv_nsec / NSEC_PER_MSEC; + tp->milli_second = ts->tv_nsec / NSEC_PER_MSEC; tp->second = tm.tm_sec; tp->minute = tm.tm_min; tp->hour = tm.tm_hour; @@ -1511,7 +1511,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info) info->CreateTimestamp.hour = tm.hour; info->CreateTimestamp.minute = tm.min; info->CreateTimestamp.second = tm.sec; - info->CreateTimestamp.MilliSecond = 0; + info->CreateTimestamp.milli_second = 0; p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY); info->ModifyTimestamp.year = tm.year; @@ -1520,7 +1520,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info) info->ModifyTimestamp.hour = tm.hour; info->ModifyTimestamp.minute = tm.min; info->ModifyTimestamp.second = tm.sec; - info->ModifyTimestamp.MilliSecond = 0; + info->ModifyTimestamp.milli_second = 0; memset((char *)&info->AccessTimestamp, 0, sizeof(struct date_time_t)); @@ -1931,7 +1931,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry) dir_entry->CreateTimestamp.hour = tm.hour; dir_entry->CreateTimestamp.minute = tm.min; dir_entry->CreateTimestamp.second = tm.sec; - dir_entry->CreateTimestamp.MilliSecond = 0; + dir_entry->CreateTimestamp.milli_second = 0; fs_func->get_entry_time(ep, &tm, TM_MODIFY); dir_entry->ModifyTimestamp.year = tm.year; @@ -1940,7 +1940,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry) dir_entry->ModifyTimestamp.hour = tm.hour; dir_entry->ModifyTimestamp.minute = tm.min; dir_entry->ModifyTimestamp.second = tm.sec; - dir_entry->ModifyTimestamp.MilliSecond = 0; + dir_entry->ModifyTimestamp.milli_second = 0; memset((char *)&dir_entry->AccessTimestamp, 0, sizeof(struct date_time_t));
Change all the occurrences of "MilliSecond" to "milli_second" in exfat. Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com> --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-)