| Message ID | 20200128110102.11522-2-martin@kaiser.cx (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | imx-rngc - several small fixes | expand |
Hi Martin, On Tue, 28 Jan 2020 at 16:31, Martin Kaiser <martin@kaiser.cx> wrote: > > Make sure that the rngc interrupt is masked if the rngc self test fails. > Self test failure means that probe fails as well. Interrupts should be > masked in this case, regardless of the error. > > Cc: stable@vger.kernel.org > Fixes: 1d5449445bd0 ("hwrng: mx-rngc - add a driver for Freescale RNGC") > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > drivers/char/hw_random/imx-rngc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c > index 30cf00f8e9a0..0576801944fd 100644 > --- a/drivers/char/hw_random/imx-rngc.c > +++ b/drivers/char/hw_random/imx-rngc.c > @@ -105,8 +105,10 @@ static int imx_rngc_self_test(struct imx_rngc *rngc) > return -ETIMEDOUT; > } > > - if (rngc->err_reg != 0) > + if (rngc->err_reg != 0) { > + imx_rngc_irq_mask_clear(rngc); > return -EIO; > + } > > return 0; > } > -- > 2.20.1 > Looks good to me. You can add Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> Regards, PrasannaKumar
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index 30cf00f8e9a0..0576801944fd 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -105,8 +105,10 @@ static int imx_rngc_self_test(struct imx_rngc *rngc) return -ETIMEDOUT; } - if (rngc->err_reg != 0) + if (rngc->err_reg != 0) { + imx_rngc_irq_mask_clear(rngc); return -EIO; + } return 0; }
Make sure that the rngc interrupt is masked if the rngc self test fails. Self test failure means that probe fails as well. Interrupts should be masked in this case, regardless of the error. Cc: stable@vger.kernel.org Fixes: 1d5449445bd0 ("hwrng: mx-rngc - add a driver for Freescale RNGC") Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- drivers/char/hw_random/imx-rngc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)