| Message ID | 20200128151942.2590-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/debugfs: remove VBT data about DRRS | expand |
On Tue, Jan 28, 2020 at 05:19:42PM +0200, Jani Nikula wrote: > The debugfs is not the place to print duplicated info about VBT data. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 8992698510ee..7f4976c10cea 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2921,16 +2921,7 @@ static void drrs_status_per_crtc(struct seq_file *m, > } > drm_connector_list_iter_end(&conn_iter); > > - if (dev_priv->vbt.drrs_type == STATIC_DRRS_SUPPORT) > - seq_puts(m, "\tVBT: DRRS_type: Static"); > - else if (dev_priv->vbt.drrs_type == SEAMLESS_DRRS_SUPPORT) > - seq_puts(m, "\tVBT: DRRS_type: Seamless"); > - else if (dev_priv->vbt.drrs_type == DRRS_NOT_SUPPORTED) > - seq_puts(m, "\tVBT: DRRS_type: None"); > - else > - seq_puts(m, "\tVBT: DRRS_type: FIXME: Unrecognized Value"); > - > - seq_puts(m, "\n\n"); > + seq_puts(m, "\n"); Less stuff to worry about for my fix drrs branch. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > if (to_intel_crtc_state(intel_crtc->base.state)->has_drrs) { > struct intel_panel *panel; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, 28 Jan 2020, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Tue, Jan 28, 2020 at 05:19:42PM +0200, Jani Nikula wrote: >> The debugfs is not the place to print duplicated info about VBT data. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/i915_debugfs.c | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c >> index 8992698510ee..7f4976c10cea 100644 >> --- a/drivers/gpu/drm/i915/i915_debugfs.c >> +++ b/drivers/gpu/drm/i915/i915_debugfs.c >> @@ -2921,16 +2921,7 @@ static void drrs_status_per_crtc(struct seq_file *m, >> } >> drm_connector_list_iter_end(&conn_iter); >> >> - if (dev_priv->vbt.drrs_type == STATIC_DRRS_SUPPORT) >> - seq_puts(m, "\tVBT: DRRS_type: Static"); >> - else if (dev_priv->vbt.drrs_type == SEAMLESS_DRRS_SUPPORT) >> - seq_puts(m, "\tVBT: DRRS_type: Seamless"); >> - else if (dev_priv->vbt.drrs_type == DRRS_NOT_SUPPORTED) >> - seq_puts(m, "\tVBT: DRRS_type: None"); >> - else >> - seq_puts(m, "\tVBT: DRRS_type: FIXME: Unrecognized Value"); >> - >> - seq_puts(m, "\n\n"); >> + seq_puts(m, "\n"); > > Less stuff to worry about for my fix drrs branch. \o/ > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Thanks for the review, pushed to dinq. BR, Jani. > >> >> if (to_intel_crtc_state(intel_crtc->base.state)->has_drrs) { >> struct intel_panel *panel; >> -- >> 2.20.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 8992698510ee..7f4976c10cea 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -2921,16 +2921,7 @@ static void drrs_status_per_crtc(struct seq_file *m, } drm_connector_list_iter_end(&conn_iter); - if (dev_priv->vbt.drrs_type == STATIC_DRRS_SUPPORT) - seq_puts(m, "\tVBT: DRRS_type: Static"); - else if (dev_priv->vbt.drrs_type == SEAMLESS_DRRS_SUPPORT) - seq_puts(m, "\tVBT: DRRS_type: Seamless"); - else if (dev_priv->vbt.drrs_type == DRRS_NOT_SUPPORTED) - seq_puts(m, "\tVBT: DRRS_type: None"); - else - seq_puts(m, "\tVBT: DRRS_type: FIXME: Unrecognized Value"); - - seq_puts(m, "\n\n"); + seq_puts(m, "\n"); if (to_intel_crtc_state(intel_crtc->base.state)->has_drrs) { struct intel_panel *panel;
The debugfs is not the place to print duplicated info about VBT data. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)