| Message ID | 20200128154614.30572-1-olaf@aepfle.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] x86/domctl: fix typo in comment | expand |
On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote: > The array is named msr_policy. > > Fixes commit 60529dfeca1 > > Signed-off-by: Olaf Hering <olaf@aepfle.de> Acked-by: Wei Liu <wl@xen.org> Backport: 4.12+ > --- > xen/include/public/domctl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index e313da499f..2bb7397923 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy { > uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to > * 'cpuid_policy'. */ > uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to > - * 'msr_domain_policy' */ > + * 'msr_policy' */ > XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */ > XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy; /* IN/OUT */ >
On 28.01.2020 17:59, Wei Liu wrote: > On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote: >> The array is named msr_policy. >> >> Fixes commit 60529dfeca1 >> >> Signed-off-by: Olaf Hering <olaf@aepfle.de> > > Acked-by: Wei Liu <wl@xen.org> > Backport: 4.12+ Why? This kind of a change hardly warrants a backport imo. Jan
On Tue, Jan 28, 2020 at 06:00:45PM +0100, Jan Beulich wrote: > On 28.01.2020 17:59, Wei Liu wrote: > > On Tue, Jan 28, 2020 at 04:46:14PM +0100, Olaf Hering wrote: > >> The array is named msr_policy. > >> > >> Fixes commit 60529dfeca1 > >> > >> Signed-off-by: Olaf Hering <olaf@aepfle.de> > > > > Acked-by: Wei Liu <wl@xen.org> > > Backport: 4.12+ > > Why? This kind of a change hardly warrants a backport imo. > I think it would be good if we can keep it in sync, but of course it is fine to not backport such fix. Wei. > Jan
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index e313da499f..2bb7397923 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -675,7 +675,7 @@ struct xen_domctl_cpu_policy { uint32_t nr_leaves; /* IN/OUT: Number of leaves in/written to * 'cpuid_policy'. */ uint32_t nr_msrs; /* IN/OUT: Number of MSRs in/written to - * 'msr_domain_policy' */ + * 'msr_policy' */ XEN_GUEST_HANDLE_64(xen_cpuid_leaf_t) cpuid_policy; /* IN/OUT */ XEN_GUEST_HANDLE_64(xen_msr_entry_t) msr_policy; /* IN/OUT */
The array is named msr_policy. Fixes commit 60529dfeca1 Signed-off-by: Olaf Hering <olaf@aepfle.de> --- xen/include/public/domctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)