| Message ID | 20200129080904.1637634-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | radeon: completely remove lut leftovers | expand |
On 2020-01-29 9:09 a.m., Daniel Vetter wrote: > This is an oversight from > > commit 42585395ebc1034a98937702849669f17eadb35f > Author: Peter Rosin <peda@axentia.se> > Date: Thu Jul 13 18:25:36 2017 +0200 > > drm: radeon: remove dead code and pointless local lut storage > > v2: Also remove leftover local variable. > > Cc: Peter Rosin <peda@axentia.se> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Michel Dänzer <michel.daenzer@amd.com> I don't think this e-mail address works anymore. > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
On Wed, Jan 29, 2020 at 4:28 AM Michel Dänzer <michel@daenzer.net> wrote: > > On 2020-01-29 9:09 a.m., Daniel Vetter wrote: > > This is an oversight from > > > > commit 42585395ebc1034a98937702849669f17eadb35f > > Author: Peter Rosin <peda@axentia.se> > > Date: Thu Jul 13 18:25:36 2017 +0200 > > > > drm: radeon: remove dead code and pointless local lut storage > > > > v2: Also remove leftover local variable. > > > > Cc: Peter Rosin <peda@axentia.se> > > Cc: Alex Deucher <alexander.deucher@amd.com> > > Cc: Michel Dänzer <michel.daenzer@amd.com> > > I don't think this e-mail address works anymore. > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> > Applied. Thanks! Alex > > -- > Earthling Michel Dänzer | https://redhat.com > Libre software enthusiast | Mesa and X developer > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 856526cb2caf..354756e00fe1 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -672,7 +672,6 @@ static void radeon_crtc_init(struct drm_device *dev, int index) { struct radeon_device *rdev = dev->dev_private; struct radeon_crtc *radeon_crtc; - int i; radeon_crtc = kzalloc(sizeof(struct radeon_crtc) + (RADEONFB_CONN_LIMIT * sizeof(struct drm_connector *)), GFP_KERNEL); if (radeon_crtc == NULL) @@ -701,12 +700,6 @@ static void radeon_crtc_init(struct drm_device *dev, int index) radeon_crtc->mode_set.num_connectors = 0; #endif - for (i = 0; i < 256; i++) { - radeon_crtc->lut_r[i] = i << 2; - radeon_crtc->lut_g[i] = i << 2; - radeon_crtc->lut_b[i] = i << 2; - } - if (rdev->is_atom_bios && (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom)) radeon_atombios_init_crtc(dev, radeon_crtc); else diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h index fd470d6bf3f4..96565171d13e 100644 --- a/drivers/gpu/drm/radeon/radeon_mode.h +++ b/drivers/gpu/drm/radeon/radeon_mode.h @@ -327,7 +327,6 @@ enum radeon_flip_status { struct radeon_crtc { struct drm_crtc base; int crtc_id; - u16 lut_r[256], lut_g[256], lut_b[256]; bool enabled; bool can_tile; bool cursor_out_of_bounds;
This is an oversight from commit 42585395ebc1034a98937702849669f17eadb35f Author: Peter Rosin <peda@axentia.se> Date: Thu Jul 13 18:25:36 2017 +0200 drm: radeon: remove dead code and pointless local lut storage v2: Also remove leftover local variable. Cc: Peter Rosin <peda@axentia.se> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Fumbled the previous patch for the regression fix (hm just realized maybe that one should have a cc: stable to make a few more people happy), wanted to include this cleanup here. -Daniel --- drivers/gpu/drm/radeon/radeon_display.c | 7 ------- drivers/gpu/drm/radeon/radeon_mode.h | 1 - 2 files changed, 8 deletions(-)