From patchwork Wed Jan 29 08:24:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11355667 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7259014E3 for ; Wed, 29 Jan 2020 08:24:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5128920708 for ; Wed, 29 Jan 2020 08:24:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="E5cyQp0r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5128920708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 560FD6F48E; Wed, 29 Jan 2020 08:24:21 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 921E76E27C for ; Wed, 29 Jan 2020 08:24:18 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id d16so19079383wre.10 for ; Wed, 29 Jan 2020 00:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AnvVhyRRmoo/xlkf99eP9Y/JmLE54NitcFMa1DSVDVE=; b=E5cyQp0rjuHu5tUyA8ZQ0acrUmQVjj2klXe6IHLgEoEfVgIU2Ui/BsJhDWMRieidAn OtjpuptoipI1m8FqdN7DyPT0uskJFPek6DTQo6GJMFckBOmACYVrjyM6dG9wbY50K940 D/HEjgQlLl8+Ufh5EEfMsT+ItQRfUNAeQ7cRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AnvVhyRRmoo/xlkf99eP9Y/JmLE54NitcFMa1DSVDVE=; b=oFv4hQ/ZAbs1Nefp85ZsdbJxygIP11VEadLHRmIsDgU/i9AuFO4U3mHg10o79kKTlW 7MKlB/mdW+PSyU33DGO80XCyWB0Y2lhud5yO5qk5+TjQUEdpacxxqAiGMctVqCXbuDOT SJggZVWHbE/4vN9+mYprhBJiFrBvg9zEvFcYz5X0hwsizXuhYNULKgHO3GbtKY5Iqxs/ t7Y2YVNEJUJpYvhNE0ideCEFSeTS6UmzMmw92Ao5g2g6mXX1qECYlFMPp18C4iCmbEMo xyItwimgPyy6YLaQsW/JMifosxZSzh6YGMOAF2PSW1an8NggXLW2rzKQIQbXUWQANQvS ky8Q== X-Gm-Message-State: APjAAAXJUQIG/IysVP12WAXSsC47tHiPiEqxSd1GT118gzS8qh0WtsCu gBlSNmT4tw+eNn0CND6401eUhEQlpjmgzg== X-Google-Smtp-Source: APXvYqynuOkbfAC0AhKxa/6O406C88xYMYBgSclcHi+aRhHzpp8zNprB077N+wPTHSrYD5VnfUJ2+w== X-Received: by 2002:adf:ebc3:: with SMTP id v3mr34841384wrn.280.1580286256970; Wed, 29 Jan 2020 00:24:16 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id n14sm1351931wmi.26.2020.01.29.00.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 00:24:16 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 1/5] drm: Complain if drivers still use the ->load callback Date: Wed, 29 Jan 2020 09:24:06 +0100 Message-Id: <20200129082410.1691996-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200129082410.1691996-1-daniel.vetter@ffwll.ch> References: <20200129082410.1691996-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Alex Deucher , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Kinda time to get this sorted. The locking around this really is not nice. Thomas mentioned in his review that the only drivers left unconverted are radeon and amdgpu. Cc: Harry Wentland Cc: Alex Deucher Reviewed-by: Chris Wilson Reviewed-by: Thomas Zimmermann Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 6 ++++++ include/drm/drm_drv.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 7c18a980cd4b..8deff75b484c 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -948,6 +948,12 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags) mutex_lock(&drm_global_mutex); + if (dev->driver->load) { + if (!drm_core_check_feature(dev, DRIVER_LEGACY)) + DRM_INFO("drm driver %s is using deprecated ->load callback\n", + dev->driver->name); + } + ret = drm_minor_register(dev, DRM_MINOR_RENDER); if (ret) goto err_minors; diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 77685ed7aa65..77bc63de0a91 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -173,6 +173,9 @@ struct drm_driver { * * This is deprecated, do not use! * + * FIXME: A few non-DRIVER_LEGACY drivers still use this, and should be + * converted. + * * Returns: * * Zero on success, non-zero value on failure.