From patchwork Wed Jan 29 18:20:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 11356655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F43B14B7 for ; Wed, 29 Jan 2020 18:20:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47BAE20708 for ; Wed, 29 Jan 2020 18:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47BAE20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3BC86F626; Wed, 29 Jan 2020 18:20:42 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 465A76F626 for ; Wed, 29 Jan 2020 18:20:41 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 10:20:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,378,1574150400"; d="scan'208";a="218028422" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 29 Jan 2020 10:20:38 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 29 Jan 2020 20:20:37 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Date: Wed, 29 Jan 2020 20:20:27 +0200 Message-Id: <20200129182034.26138-2-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200129182034.26138-1-ville.syrjala@linux.intel.com> References: <20200129182034.26138-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/9] drm/i915/dsb: Disable DSB until fixed X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Our DSB support is borked. The DSB seems to get stuck and we just get: [drm:intel_dsb_commit [i915]] DSB execution started - head 0xa8c000, tail 0x10c0 [drm:intel_dsb_commit [i915]] *ERROR* Timed out waiting for DSB workload completion. [drm:icl_load_luts [i915]] DSB engine is busy. Which even seems to result in underruns on some internal stuff. Let's just disable it all until someone figures out what's wrong with it. Signed-off-by: Ville Syrjälä Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dsb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index 12776f09f227..a16a78cd0ebe 100644 --- a/drivers/gpu/drm/i915/display/intel_dsb.c +++ b/drivers/gpu/drm/i915/display/intel_dsb.c @@ -105,7 +105,11 @@ intel_dsb_get(struct intel_crtc *crtc) u32 *buf; intel_wakeref_t wakeref; - if (!HAS_DSB(i915)) + /* + * FIXME DSB support is busted. DSB tends to be + * busy when it shouldn't be. Disable until fixed. + */ + if (true || !HAS_DSB(i915)) return dsb; if (dsb->refcount++ != 0)