[v2] iwlwifi: fix config variable name in comment
diff mbox series

Message ID 20200130080622.1927-1-luca@lucaceresoli.net
State New
Delegated to: Luca Coelho
Headers show
Series
  • [v2] iwlwifi: fix config variable name in comment
Related show

Commit Message

Luca Ceresoli Jan. 30, 2020, 8:06 a.m. UTC
The correct variable name was replaced here by mistake.

Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0 and 11ac RF modules")
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes in v2:
 - rebased on current master fixing conflicts
---
 drivers/net/wireless/intel/iwlwifi/iwl-config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Jan. 30, 2020, 8:54 a.m. UTC | #1
Luca Ceresoli <luca@lucaceresoli.net> writes:

> The correct variable name was replaced here by mistake.
>
> Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0
> and 11ac RF modules")

The Fixes tag should be all in one line. But TBH I'm not sure if it
makes sense to add that to a patch which has no functional changes like
this one.
Luca Ceresoli Feb. 10, 2020, 1:59 p.m. UTC | #2
Hi Kalle,

On 30/01/20 09:54, Kalle Valo wrote:
> Luca Ceresoli <luca@lucaceresoli.net> writes:
> 
>> The correct variable name was replaced here by mistake.
>>
>> Fixes: ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0
>> and 11ac RF modules")
> 
> The Fixes tag should be all in one line. But TBH I'm not sure if it
> makes sense to add that to a patch which has no functional changes like
> this one.

Ok, I agree this is a gray area. Just sent v3 without the Fixes tag.

Thanks,

Patch
diff mbox series

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-config.h b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
index be6a2bf9ce74..df2d3257cce2 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-config.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
@@ -600,6 +600,6 @@  extern const struct iwl_cfg iwlax211_2ax_cfg_so_gf_a0;
 extern const struct iwl_cfg iwlax210_2ax_cfg_ty_gf_a0;
 extern const struct iwl_cfg iwlax411_2ax_cfg_so_gf4_a0;
 extern const struct iwl_cfg iwlax411_2ax_cfg_sosnj_gf4_a0;
-#endif /* CPTCFG_IWLMVM || CPTCFG_IWLFMAC */
+#endif /* CONFIG_IWLMVM */
 
 #endif /* __IWL_CONFIG_H__ */