rbd: remove barriers from img_request_layered_{set,clear,test}()
diff mbox series

Message ID 20200130133102.13745-1-idryomov@gmail.com
State New
Headers show
Series
  • rbd: remove barriers from img_request_layered_{set,clear,test}()
Related show

Commit Message

Ilya Dryomov Jan. 30, 2020, 1:31 p.m. UTC
IMG_REQ_LAYERED is set in rbd_img_request_create(), and tested and
cleared in rbd_img_request_destroy() when the image request is about to
be destroyed.  The barriers are unnecessary.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---
 drivers/block/rbd.c | 3 ---
 1 file changed, 3 deletions(-)

Patch
diff mbox series

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index f21f9bc8d74a..4e494d5600cc 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -1371,18 +1371,15 @@  static void rbd_osd_submit(struct ceph_osd_request *osd_req)
 static void img_request_layered_set(struct rbd_img_request *img_request)
 {
 	set_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static void img_request_layered_clear(struct rbd_img_request *img_request)
 {
 	clear_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static bool img_request_layered_test(struct rbd_img_request *img_request)
 {
-	smp_mb();
 	return test_bit(IMG_REQ_LAYERED, &img_request->flags) != 0;
 }