diff mbox series

README: fsgqa needs a home directory too

Message ID alpine.DEB.2.22.395.2001311318390.2831@trent.utfs.org (mailing list archive)
State New, archived
Headers show
Series README: fsgqa needs a home directory too | expand

Commit Message

Christian Kujau Jan. 31, 2020, 9:22 p.m. UTC
generic/128 whould fail with:

     QA output created by 128
    +su: warning: cannot change directory to /home/fsgqa: No such file or directory

Adjust README to create a home directory too. And (totally unrelated), 
fix the 404 for the udf_test tool.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Comments

Eryu Guan Feb. 17, 2020, 12:53 p.m. UTC | #1
On Fri, Jan 31, 2020 at 01:22:49PM -0800, Christian Kujau wrote:
> generic/128 whould fail with:
> 
>      QA output created by 128
>     +su: warning: cannot change directory to /home/fsgqa: No such file or directory
> 
> Adjust README to create a home directory too. And (totally unrelated), 
> fix the 404 for the udf_test tool.
> 
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Ok, your patch is missing the "---" below Signed-off-by line

---

above dashes make the patch appliable.

Thanks,
Eryu

> 
> --- README.orig	2020-01-12 08:43:34.000000000 -0800
> +++ README	2020-01-31 13:18:12.494026480 -0800
> @@ -19,7 +19,7 @@
>  	(Note that for RHEL and CentOS, you may need the EPEL repo.)
>  - run make
>  - run make install
> -- create fsgqa test user ("sudo useradd fsgqa")
> +- create fsgqa test user ("sudo useradd -m fsgqa")
>  - create fsgqa group ("sudo groupadd fsgqa")
>  - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
>  
> @@ -33,7 +33,7 @@
>      - install administrative tools specific to the filesystem you wish to test
>      - If you wish to run the udf components of the suite install
>        mkudffs. Also download and build the Philips UDF Verification Software
> -      from http://www.extra.research.philips.com/udf/, then copy the udf_test
> +      from https://www.lscdweb.com/registered/udf_verifier.html, then copy the udf_test
>        binary to xfstests/src/. If you wish to disable UDF verification test
>        set the environment variable DISABLE_UDF_TEST to 1.
>  
> 
> -- 
> BOFH excuse #220:
> 
> Someone thought The Big Red Button was a light switch.
Christian Kujau Feb. 19, 2020, 12:33 a.m. UTC | #2
On Mon, 17 Feb 2020, Eryu Guan wrote:
> > Signed-off-by: Christian Kujau <lists@nerdbynature.de>
> 
> Ok, your patch is missing the "---" below Signed-off-by line
> 
> ---
> 
> above dashes make the patch appliable.

Sorry for that, next time I'll try to use scripts/checkpatch.pl from the 
Kernel project before submitting patches.

Thanks for applying this.

Christian.
diff mbox series

Patch

--- README.orig	2020-01-12 08:43:34.000000000 -0800
+++ README	2020-01-31 13:18:12.494026480 -0800
@@ -19,7 +19,7 @@ 
 	(Note that for RHEL and CentOS, you may need the EPEL repo.)
 - run make
 - run make install
-- create fsgqa test user ("sudo useradd fsgqa")
+- create fsgqa test user ("sudo useradd -m fsgqa")
 - create fsgqa group ("sudo groupadd fsgqa")
 - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
 
@@ -33,7 +33,7 @@ 
     - install administrative tools specific to the filesystem you wish to test
     - If you wish to run the udf components of the suite install
       mkudffs. Also download and build the Philips UDF Verification Software
-      from http://www.extra.research.philips.com/udf/, then copy the udf_test
+      from https://www.lscdweb.com/registered/udf_verifier.html, then copy the udf_test
       binary to xfstests/src/. If you wish to disable UDF verification test
       set the environment variable DISABLE_UDF_TEST to 1.