[ndctl] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am
diff mbox series

Message ID 20200131224756.29821-1-vishal.l.verma@intel.com
State New
Headers show
Series
  • [ndctl] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am
Related show

Commit Message

Verma, Vishal L Jan. 31, 2020, 10:47 p.m. UTC
ndctl/Makefile.am neglected to explicitly add util/filter.{c,h} to
ndctl_SOURCES. In the past, this has been a cause for distro build
failures.

Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Dan Williams Jan. 31, 2020, 11:33 p.m. UTC | #1
On Fri, Jan 31, 2020 at 2:48 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> ndctl/Makefile.am neglected to explicitly add util/filter.{c,h} to
> ndctl_SOURCES. In the past, this has been a cause for distro build
> failures.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  ndctl/Makefile.am | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
> index 264c4ed..49c6c4a 100644
> --- a/ndctl/Makefile.am
> +++ b/ndctl/Makefile.am
> @@ -18,7 +18,9 @@ ndctl_SOURCES = ndctl.c \
>                 check.c \
>                 region.c \
>                 dimm.c \
> -                ../util/log.c \
> +               ../util/log.c \
> +               ../util/filter.c \
> +               ../util/filter.h \

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Not sure why 'make distcheck' did not hit this previously.

Patch
diff mbox series

diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
index 264c4ed..49c6c4a 100644
--- a/ndctl/Makefile.am
+++ b/ndctl/Makefile.am
@@ -18,7 +18,9 @@  ndctl_SOURCES = ndctl.c \
 		check.c \
 		region.c \
 		dimm.c \
-		 ../util/log.c \
+		../util/log.c \
+		../util/filter.c \
+		../util/filter.h \
 		list.c \
 		../util/json.c \
 		../util/json.h \