[2/2] ALSA: hdsp: Make the firmware loading ioctl a bit more readable
diff mbox series

Message ID 20200202090724.18232-2-tiwai@suse.de
State New
Headers show
  • [1/2] ALSA: emu10k1: Fix annotation and cast for the recent uapi header change
Related show

Commit Message

Takashi Iwai Feb. 2, 2020, 9:07 a.m. UTC
The firmware loading ioctl that is implemented for hdsp hwdep device
takes the reference of the address pointer, hence the current code is
rather confusing.  Also, due to the recent change in uapi header,
sparse also complains about the cast.

This patch tries to improve the readability by converting the
straightforward copy_from_user of the whole struct (which contains
only the pointer).

Fixes: d63e63d42107 ("ALSA: hdsp: Make uapi/hdsp.h compilable again")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
 sound/pci/rme9652/hdsp.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff mbox series

diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index ba2a47dd384c..25b3c5697343 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -4802,7 +4802,7 @@  static int snd_hdsp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, unsigne
-		struct hdsp_firmware __user *firmware;
+		struct hdsp_firmware firmware;
 		u32 __user *firmware_data;
 		int err;
@@ -4815,10 +4815,9 @@  static int snd_hdsp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, unsigne
 			 "initializing firmware upload\n");
-		firmware = (struct hdsp_firmware __user *)argp;
-		if (get_user(firmware_data, (__force void __user **)&firmware->firmware_data))
+		if (copy_from_user(&firmware, argp, sizeof(firmware)))
 			return -EFAULT;
+		firmware_data = (u32 __user *)firmware.firmware_data;
 		if (hdsp_check_for_iobox (hdsp))
 			return -EIO;