[RFC] ceph: fix the debug message for calc_layout
diff mbox series

Message ID 20200203040133.39319-1-xiubli@redhat.com
State New
Headers show
Series
  • [RFC] ceph: fix the debug message for calc_layout
Related show

Commit Message

Xiubo Li Feb. 3, 2020, 4:01 a.m. UTC
From: Xiubo Li <xiubli@redhat.com>

Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
 net/ceph/osd_client.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ilya Dryomov Feb. 3, 2020, 10:25 a.m. UTC | #1
On Mon, Feb 3, 2020 at 5:02 AM <xiubli@redhat.com> wrote:
>
> From: Xiubo Li <xiubli@redhat.com>
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  net/ceph/osd_client.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 108c9457d629..6afe36ffc1ba 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
>         if (*objlen < orig_len) {
>                 *plen = *objlen;
>                 dout(" skipping last %llu, final file extent %llu~%llu\n",
> -                    orig_len - *plen, off, *plen);
> +                    orig_len - *plen, off, off + *plen);
>         }
>
> -       dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
> +       dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
> +            *objoff, *objoff + *objlen);

Hi Xiubo,

offset~length is how extents are printed both on the OSD side and
elsewhere in the kernel client.

Thanks,

                Ilya
Xiubo Li Feb. 3, 2020, 10:46 a.m. UTC | #2
On 2020/2/3 18:25, Ilya Dryomov wrote:
> On Mon, Feb 3, 2020 at 5:02 AM <xiubli@redhat.com> wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>   net/ceph/osd_client.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
>> index 108c9457d629..6afe36ffc1ba 100644
>> --- a/net/ceph/osd_client.c
>> +++ b/net/ceph/osd_client.c
>> @@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
>>          if (*objlen < orig_len) {
>>                  *plen = *objlen;
>>                  dout(" skipping last %llu, final file extent %llu~%llu\n",
>> -                    orig_len - *plen, off, *plen);
>> +                    orig_len - *plen, off, off + *plen);
>>          }
>>
>> -       dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
>> +       dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
>> +            *objoff, *objoff + *objlen);
> Hi Xiubo,
>
> offset~length is how extents are printed both on the OSD side and
> elsewhere in the kernel client.

Okay, so my understanding is not correct then.

Thanks.


> Thanks,
>
>                  Ilya
>

Patch
diff mbox series

diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 108c9457d629..6afe36ffc1ba 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -113,10 +113,11 @@  static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen,
 	if (*objlen < orig_len) {
 		*plen = *objlen;
 		dout(" skipping last %llu, final file extent %llu~%llu\n",
-		     orig_len - *plen, off, *plen);
+		     orig_len - *plen, off, off + *plen);
 	}
 
-	dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
+	dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum,
+	     *objoff, *objoff + *objlen);
 	return 0;
 }