From patchwork Mon Feb 3 06:10:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 11362069 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6E4D17E0 for ; Mon, 3 Feb 2020 06:12:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDBCA2082F for ; Mon, 3 Feb 2020 06:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="dkULL3hY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDBCA2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:34748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUyT-0004Ld-TF for patchwork-qemu-devel@patchwork.kernel.org; Mon, 03 Feb 2020 01:12:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57138) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUxM-0002Lh-3C for qemu-devel@nongnu.org; Mon, 03 Feb 2020 01:11:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyUxL-0002Wc-4A for qemu-devel@nongnu.org; Mon, 03 Feb 2020 01:11:36 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:53705) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyUxJ-0002OE-4m; Mon, 03 Feb 2020 01:11:35 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 489yBm07Clz9sS9; Mon, 3 Feb 2020 17:11:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1580710288; bh=dCdn1ruMSLsjZuuCJv7VxVhSfR0TgqtIsrQxGA4YTIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dkULL3hYJ5AYoEZtkQOA+KJHTjxYQ5vc69s3w94ebX4Alkrus+NciUZbYU3CKgv2w vsRW0pwTdilWq7Z+P3TfEhRWDuKAIeZK8DJQq1VkJPnWyBBgvvU4LwCiKTwmYUg1Nh Rqhnp9V80LtqG4nSDFFEAk993QamicswhUysI0DQ= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 02/35] ppc/pnv: improve error logging when a PNOR update fails Date: Mon, 3 Feb 2020 17:10:50 +1100 Message-Id: <20200203061123.59150-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200203061123.59150-1-david@gibson.dropbear.id.au> References: <20200203061123.59150-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Cédric Le Goater Print out the offset at which the error occured. Signed-off-by: Cédric Le Goater Message-Id: <20200108090348.21224-3-clg@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index 060c6e6a31..c365ee58b8 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -47,7 +47,8 @@ static void pnv_pnor_update(PnvPnor *s, int offset, int size) ret = blk_pwrite(s->blk, offset, s->storage + offset, offset_end - offset, 0); if (ret < 0) { - error_report("Could not update PNOR: %s", strerror(-ret)); + error_report("Could not update PNOR offset=0x%" PRIx32" : %s", offset, + strerror(-ret)); } }