[v1] drm: shmobile: Platform data shan't include kernel.h
diff mbox series

Message ID 20200204161916.28744-1-andriy.shevchenko@linux.intel.com
State New
Delegated to: Kieran Bingham
Headers show
Series
  • [v1] drm: shmobile: Platform data shan't include kernel.h
Related show

Commit Message

Andy Shevchenko Feb. 4, 2020, 4:19 p.m. UTC
Replace with appropriate types.h.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/platform_data/shmob_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Feb. 4, 2020, 5:39 p.m. UTC | #1
Hi Andy,

On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Replace with appropriate types.h.

Thanks for your patch!

I have only one very short question: why?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Laurent Pinchart Feb. 4, 2020, 6:26 p.m. UTC | #2
On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > Replace with appropriate types.h.
> 
> Thanks for your patch!
> 
> I have only one very short question: why?

Likewise :-) The patch itself looks fine, but the commit message is a
bit terse.
Andy Shevchenko Feb. 4, 2020, 7:30 p.m. UTC | #3
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> > 
> > Thanks for your patch!
> > 
> > I have only one very short question: why?
> 
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.

The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.

Any suggestion what should I put to commit message?
Geert Uytterhoeven Feb. 4, 2020, 7:44 p.m. UTC | #4
Hi Andy,

On Tue, Feb 4, 2020 at 8:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > > Replace with appropriate types.h.
> > >
> > > Thanks for your patch!
> > >
> > > I have only one very short question: why?
> >
> > Likewise :-) The patch itself looks fine, but the commit message is a
> > bit terse.
>
> The kernel.h for a long time being a dump of a lot of things. I started
> cleaning it up a bit. During this I notice that developers too far too lazy to
> use appropriate headers. For platform data kernel.h by definition is not
> appropriate.

Thanks, that makes perfect sense.

> Any suggestion what should I put to commit message?

I became intrigued by the one-line summary, which seemed to suggest
(according to my interpretation) that including kernel.h is a Real Bad
Thing.

But basically all you wanted to say was:

    drm: shmobile: Reduce include dependencies

and:

    This file doesn't need everything provided by <linux/kernel.h>.
    All it needs are some types, which are provided by <linux/types.h>.

Right?

BTW, <drm/drm_mode.h> already includes <linux/types.h>, but not relying
on implicit includes is indeed a good thing.

Gr{oetje,eeting}s,

                        Geert

Patch
diff mbox series

diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..08605fdb2226 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,7 +10,7 @@ 
 #ifndef __SHMOB_DRM_H__
 #define __SHMOB_DRM_H__
 
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 #include <drm/drm_mode.h>