From patchwork Tue Feb 4 21:49:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Druzhinin X-Patchwork-Id: 11365293 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D35D414B4 for ; Tue, 4 Feb 2020 21:51:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE9872084E for ; Tue, 4 Feb 2020 21:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="MK6IjHxc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE9872084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iz64r-0000wP-1r; Tue, 04 Feb 2020 21:49:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iz64q-0000wJ-JN for xen-devel@lists.xenproject.org; Tue, 04 Feb 2020 21:49:48 +0000 X-Inumbo-ID: 40c2782c-4798-11ea-9026-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 40c2782c-4798-11ea-9026-12813bfff9fa; Tue, 04 Feb 2020 21:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1580852983; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=RKbuWJWH3gHV/V5tipvNpTzFzBPm/XK6B4kBhfD1mKA=; b=MK6IjHxc7opVs4L+/r/0dqeEQ0/ftLZwwFb//yO51bB0YlZGFXIw16+p 2/IYCmLosE/PWzOowvdnqzFEpo7MnYpboVM4zsRZSgn+AhNh69ZBN/T9e BeWKOavJCFm9E2j/+4Eoo4WD+JpTjTPvUGQx24znA+44QTLCp9Vg9wSvX Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: j72BCuRmGm1CRLUEsyW+WS2J3ZXMm6I3i36usrXZ5KsbhBarh4C4lVd3Frt5S3+rIejlgZLKeT H2t6v/1S4kCF2cy1XTVRVSiFRkSnC3YZ3nrNXgkXMApJKtImh0droCH4//F7KdC5QQw8Na3PVc ATS/LCZXQyMF8FtMxGWxgQe5OKbkKk9j6WPfUzOCnuLorsGER6mrzKdFWv4wCMQJ1sx940lWw4 2jnrov02hzoYqgalfWQeXD4xP0oVeGPtEP+AopOannT5ttKIZREmc7eHA97EEUdc+I0UYE0HMl qi4= X-SBRS: 2.7 X-MesageID: 12319355 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,403,1574139600"; d="scan'208";a="12319355" From: Igor Druzhinin To: Date: Tue, 4 Feb 2020 21:49:37 +0000 Message-ID: <1580852977-23866-3-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1580852977-23866-1-git-send-email-igor.druzhinin@citrix.com> References: <1580852977-23866-1-git-send-email-igor.druzhinin@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 2/2] x86/time: report correct frequency of Xen PV clocksource X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: andrew.cooper3@citrix.com, Igor Druzhinin , wl@xen.org, jbeulich@suse.com, roger.pau@citrix.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The value of the counter represents the number of nanoseconds since host boot. That means the correct frequency is always 1GHz. This inconsistency caused time to go slower in PV shim on most platforms. Signed-off-by: Igor Druzhinin Reviewed-by: Roger Pau Monné --- xen/arch/x86/time.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c index 7e7a62e..26f9bad 100644 --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -587,9 +587,7 @@ static int64_t __init init_xen_timer(struct platform_timesource *pts) if ( !xen_guest ) return 0; - pts->frequency = xen_timer_cpu_frequency(); - - return pts->frequency; + return xen_timer_cpu_frequency(); } static always_inline uint64_t read_cycle(const struct vcpu_time_info *info, @@ -643,6 +641,7 @@ static struct platform_timesource __initdata plt_xen_timer = { .id = "xen", .name = "XEN PV CLOCK", + .frequency = 1000000000ULL, .read_counter = read_xen_timer, .init = init_xen_timer, .resume = resume_xen_timer,