[1/4] libxfs: re-sort libxfs_api_defs.h defines
diff mbox series

Message ID 158086357391.2079557.7271114884346251108.stgit@magnolia
State Accepted
Headers show
Series
  • xfsprogs: random fixes
Related show

Commit Message

Darrick J. Wong Feb. 5, 2020, 12:46 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Re-fix the sorting in this file.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 libxfs/libxfs_api_defs.h |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Chaitanya Kulkarni Feb. 5, 2020, 2:11 a.m. UTC | #1
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 02/04/2020 04:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong<darrick.wong@oracle.com>
>
> Re-fix the sorting in this file.
>
> Signed-off-by: Darrick J. Wong<darrick.wong@oracle.com>
Allison Collins Feb. 5, 2020, 5:28 a.m. UTC | #2
On 2/4/20 5:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Re-fix the sorting in this file.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks ok to me
Reviewed-by: Allison Collins <allison.henderson@oracle.com>

> ---
>   libxfs/libxfs_api_defs.h |    9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> 
> diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h
> index c7fa1607..6e09685b 100644
> --- a/libxfs/libxfs_api_defs.h
> +++ b/libxfs/libxfs_api_defs.h
> @@ -93,6 +93,7 @@
>   #define xfs_dqblk_repair		libxfs_dqblk_repair
>   #define xfs_dquot_verify		libxfs_dquot_verify
>   
> +#define xfs_finobt_calc_reserves	libxfs_finobt_calc_reserves
>   #define xfs_free_extent			libxfs_free_extent
>   #define xfs_fs_geometry			libxfs_fs_geometry
>   #define xfs_highbit32			libxfs_highbit32
> @@ -118,13 +119,16 @@
>   #define xfs_perag_put			libxfs_perag_put
>   #define xfs_prealloc_blocks		libxfs_prealloc_blocks
>   
> +#define xfs_read_agf			libxfs_read_agf
>   #define xfs_refc_block			libxfs_refc_block
> +#define xfs_refcountbt_calc_reserves	libxfs_refcountbt_calc_reserves
>   #define xfs_refcountbt_init_cursor	libxfs_refcountbt_init_cursor
>   #define xfs_refcountbt_maxrecs		libxfs_refcountbt_maxrecs
>   #define xfs_refcount_get_rec		libxfs_refcount_get_rec
>   #define xfs_refcount_lookup_le		libxfs_refcount_lookup_le
>   
>   #define xfs_rmap_alloc			libxfs_rmap_alloc
> +#define xfs_rmapbt_calc_reserves	libxfs_rmapbt_calc_reserves
>   #define xfs_rmapbt_init_cursor		libxfs_rmapbt_init_cursor
>   #define xfs_rmapbt_maxrecs		libxfs_rmapbt_maxrecs
>   #define xfs_rmap_compare		libxfs_rmap_compare
> @@ -176,9 +180,6 @@
>   #define xfs_verify_rtbno		libxfs_verify_rtbno
>   #define xfs_zero_extent			libxfs_zero_extent
>   
> -#define xfs_refcountbt_calc_reserves	libxfs_refcountbt_calc_reserves
> -#define xfs_finobt_calc_reserves	libxfs_finobt_calc_reserves
> -#define xfs_rmapbt_calc_reserves	libxfs_rmapbt_calc_reserves
> -#define xfs_read_agf			libxfs_read_agf
> +/* Please keep this list alphabetized. */
>   
>   #endif /* __LIBXFS_API_DEFS_H__ */
>
Christoph Hellwig Feb. 17, 2020, 1:45 p.m. UTC | #3
On Tue, Feb 04, 2020 at 04:46:13PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Re-fix the sorting in this file.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch
diff mbox series

diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h
index c7fa1607..6e09685b 100644
--- a/libxfs/libxfs_api_defs.h
+++ b/libxfs/libxfs_api_defs.h
@@ -93,6 +93,7 @@ 
 #define xfs_dqblk_repair		libxfs_dqblk_repair
 #define xfs_dquot_verify		libxfs_dquot_verify
 
+#define xfs_finobt_calc_reserves	libxfs_finobt_calc_reserves
 #define xfs_free_extent			libxfs_free_extent
 #define xfs_fs_geometry			libxfs_fs_geometry
 #define xfs_highbit32			libxfs_highbit32
@@ -118,13 +119,16 @@ 
 #define xfs_perag_put			libxfs_perag_put
 #define xfs_prealloc_blocks		libxfs_prealloc_blocks
 
+#define xfs_read_agf			libxfs_read_agf
 #define xfs_refc_block			libxfs_refc_block
+#define xfs_refcountbt_calc_reserves	libxfs_refcountbt_calc_reserves
 #define xfs_refcountbt_init_cursor	libxfs_refcountbt_init_cursor
 #define xfs_refcountbt_maxrecs		libxfs_refcountbt_maxrecs
 #define xfs_refcount_get_rec		libxfs_refcount_get_rec
 #define xfs_refcount_lookup_le		libxfs_refcount_lookup_le
 
 #define xfs_rmap_alloc			libxfs_rmap_alloc
+#define xfs_rmapbt_calc_reserves	libxfs_rmapbt_calc_reserves
 #define xfs_rmapbt_init_cursor		libxfs_rmapbt_init_cursor
 #define xfs_rmapbt_maxrecs		libxfs_rmapbt_maxrecs
 #define xfs_rmap_compare		libxfs_rmap_compare
@@ -176,9 +180,6 @@ 
 #define xfs_verify_rtbno		libxfs_verify_rtbno
 #define xfs_zero_extent			libxfs_zero_extent
 
-#define xfs_refcountbt_calc_reserves	libxfs_refcountbt_calc_reserves
-#define xfs_finobt_calc_reserves	libxfs_finobt_calc_reserves
-#define xfs_rmapbt_calc_reserves	libxfs_rmapbt_calc_reserves
-#define xfs_read_agf			libxfs_read_agf
+/* Please keep this list alphabetized. */
 
 #endif /* __LIBXFS_API_DEFS_H__ */