[1/5] ui: add show-cursor option
diff mbox series

Message ID 20200205110356.3491-2-kraxel@redhat.com
State New
Headers show
Series
  • ui: rework -show-cursor option
Related show

Commit Message

Gerd Hoffmann Feb. 5, 2020, 11:03 a.m. UTC
When enabled forces showing a the mouse cursor, i.e. do
nowallow the guest to hide it.  Defaults to off.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qapi/ui.json | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Blake Feb. 5, 2020, 10:23 p.m. UTC | #1
On 2/5/20 5:03 AM, Gerd Hoffmann wrote:
> When enabled forces showing a the mouse cursor, i.e. do

When enabled, this forces showing the mouse...

> nowallow the guest to hide it.  Defaults to off.

s/nowallow/not allow/

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   qapi/ui.json | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/qapi/ui.json b/qapi/ui.json
> index e04525d8b44b..7c516a455631 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1144,6 +1144,7 @@
>   # @type:          Which DisplayType qemu should use.
>   # @full-screen:   Start user interface in fullscreen mode (default: off).
>   # @window-close:  Allow to quit qemu with window close button (default: on).
> +# @show-cursor:   Force showing the mouse cursor (default: off).
>   # @gl:            Enable OpenGL support (default: off).
>   #
>   # Since: 2.12

Missing a '(since 5.0)' tag.

> @@ -1153,6 +1154,7 @@
>     'base'    : { 'type'           : 'DisplayType',
>                   '*full-screen'   : 'bool',
>                   '*window-close'  : 'bool',
> +                '*show-cursor'   : 'bool',
>                   '*gl'            : 'DisplayGLMode' },
>     'discriminator' : 'type',
>     'data'    : { 'gtk'            : 'DisplayGTK',
>
Ján Tomko Feb. 5, 2020, 10:44 p.m. UTC | #2
On Wed, Feb 05, 2020 at 12:03:52PM +0100, Gerd Hoffmann wrote:
>When enabled forces showing a the mouse cursor, i.e. do
>nowallow the guest to hide it.  Defaults to off.
>
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> qapi/ui.json | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Patch
diff mbox series

diff --git a/qapi/ui.json b/qapi/ui.json
index e04525d8b44b..7c516a455631 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -1144,6 +1144,7 @@ 
 # @type:          Which DisplayType qemu should use.
 # @full-screen:   Start user interface in fullscreen mode (default: off).
 # @window-close:  Allow to quit qemu with window close button (default: on).
+# @show-cursor:   Force showing the mouse cursor (default: off).
 # @gl:            Enable OpenGL support (default: off).
 #
 # Since: 2.12
@@ -1153,6 +1154,7 @@ 
   'base'    : { 'type'           : 'DisplayType',
                 '*full-screen'   : 'bool',
                 '*window-close'  : 'bool',
+                '*show-cursor'   : 'bool',
                 '*gl'            : 'DisplayGLMode' },
   'discriminator' : 'type',
   'data'    : { 'gtk'            : 'DisplayGTK',