| Message ID | 20200205140130.164805-1-chenzhou10@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9ce9a5d5c362e392791319edef4ef918ed0ddfca |
| Headers | show |
| Series | [-next] crypto: allwinner - remove redundant platform_get_irq error message | expand |
On Wed, Feb 05, 2020 at 10:01:30PM +0800, Chen Zhou wrote: > Function dev_err() after platform_get_irq() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c index f72346a..3e4e4bb 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c @@ -565,10 +565,8 @@ static int sun8i_ce_probe(struct platform_device *pdev) /* Get Non Secure IRQ */ irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(ce->dev, "Cannot get CryptoEngine Non-secure IRQ\n"); + if (irq < 0) return irq; - } ce->reset = devm_reset_control_get(&pdev->dev, NULL); if (IS_ERR(ce->reset)) {
Function dev_err() after platform_get_irq() is redundant because platform_get_irq() already prints an error. Signed-off-by: Chen Zhou <chenzhou10@huawei.com> --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)