[v3] drm: shmobile: Reduce include dependencies
diff mbox series

Message ID 20200206111232.75309-1-andriy.shevchenko@linux.intel.com
State New
Delegated to: Kieran Bingham
Headers show
Series
  • [v3] drm: shmobile: Reduce include dependencies
Related show

Commit Message

Andy Shevchenko Feb. 6, 2020, 11:12 a.m. UTC
This file doesn't need everything provided by <linux/kernel.h>.
All it needs are some types, which are provided by <drm/drm_mode.h>.

Drop unneeded <linux/kernel.h> completely.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: Drop header completely (Laurent)
 include/linux/platform_data/shmob_drm.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko Feb. 24, 2020, 9:04 a.m. UTC | #1
On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
> This file doesn't need everything provided by <linux/kernel.h>.
> All it needs are some types, which are provided by <drm/drm_mode.h>.
> 
> Drop unneeded <linux/kernel.h> completely.

Any comments on this?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: Drop header completely (Laurent)
>  include/linux/platform_data/shmob_drm.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> index fe815d7d9f58..d661399b217d 100644
> --- a/include/linux/platform_data/shmob_drm.h
> +++ b/include/linux/platform_data/shmob_drm.h
> @@ -10,8 +10,6 @@
>  #ifndef __SHMOB_DRM_H__
>  #define __SHMOB_DRM_H__
>  
> -#include <linux/kernel.h>
> -
>  #include <drm/drm_mode.h>
>  
>  enum shmob_drm_clk_source {
> -- 
> 2.24.1
>
Laurent Pinchart Feb. 26, 2020, 1:44 a.m. UTC | #2
Hi Andy,

Thank you for the patch, and sorry for the delay.

On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote:
> On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
> > This file doesn't need everything provided by <linux/kernel.h>.

s/everything/anything/

> > All it needs are some types, which are provided by <drm/drm_mode.h>.
> > 
> > Drop unneeded <linux/kernel.h> completely.
> 
> Any comments on this?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Feel free to push :-)

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v3: Drop header completely (Laurent)
> >  include/linux/platform_data/shmob_drm.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> > index fe815d7d9f58..d661399b217d 100644
> > --- a/include/linux/platform_data/shmob_drm.h
> > +++ b/include/linux/platform_data/shmob_drm.h
> > @@ -10,8 +10,6 @@
> >  #ifndef __SHMOB_DRM_H__
> >  #define __SHMOB_DRM_H__
> >  
> > -#include <linux/kernel.h>
> > -
> >  #include <drm/drm_mode.h>
> >  
> >  enum shmob_drm_clk_source {

Patch
diff mbox series

diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..d661399b217d 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,8 +10,6 @@ 
 #ifndef __SHMOB_DRM_H__
 #define __SHMOB_DRM_H__
 
-#include <linux/kernel.h>
-
 #include <drm/drm_mode.h>
 
 enum shmob_drm_clk_source {