| Message ID | 20200207103012.27049-3-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: Cover orphean qapi/json files | expand |
On 07.02.20 11:30, Philippe Mathieu-Daudé wrote: > List this file in the proper section, so maintainers get > notified when it is modified. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > Cc: qemu-block@nongnu.org > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Max Reitz <mreitz@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > List this file in the proper section, so maintainers get > notified when it is modified. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > Cc: qemu-block@nongnu.org > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 903831e0a4..e269e9092c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1842,6 +1842,8 @@ S: Supported Block layer core M: Kevin Wolf <kwolf@redhat.com> M: Max Reitz <mreitz@redhat.com> L: qemu-block@nongnu.org S: Supported > F: block* > F: block/ > F: hw/block/ > +F: qapi/block.json > +F: qapi/block-core.json > F: include/block/ > F: qemu-img* > F: docs/interop/qemu-img.rst This is in addition to Block QAPI, monitor, command line M: Markus Armbruster <armbru@redhat.com> S: Supported F: blockdev.c F: block/qapi.c F: qapi/block*.json F: qapi/transaction.json T: git https://repo.or.cz/qemu/armbru.git block-next I'm not sure this section makes much sense anymore. Should qapi/transaction.json also be added to "Block layer core"? Or should it go into John's section "Block Jobs"?
Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben: > Philippe Mathieu-Daudé <philmd@redhat.com> writes: > > > List this file in the proper section, so maintainers get > > notified when it is modified. > > > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > --- > > Cc: Kevin Wolf <kwolf@redhat.com> > > Cc: Max Reitz <mreitz@redhat.com> > > Cc: qemu-block@nongnu.org > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 903831e0a4..e269e9092c 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1842,6 +1842,8 @@ S: Supported > Block layer core > M: Kevin Wolf <kwolf@redhat.com> > M: Max Reitz <mreitz@redhat.com> > L: qemu-block@nongnu.org > S: Supported > > F: block* > > F: block/ > > F: hw/block/ > > +F: qapi/block.json > > +F: qapi/block-core.json > > F: include/block/ > > F: qemu-img* > > F: docs/interop/qemu-img.rst > > This is in addition to > > Block QAPI, monitor, command line > M: Markus Armbruster <armbru@redhat.com> > S: Supported > F: blockdev.c > F: block/qapi.c > F: qapi/block*.json > F: qapi/transaction.json > T: git https://repo.or.cz/qemu/armbru.git block-next > > I'm not sure this section makes much sense anymore. This is probably for you to decide. Though the block-next branch from the T: line doesn't even exist any more... > Should qapi/transaction.json also be added to "Block layer core"? Or > should it go into John's section "Block Jobs"? I think at the moment it only supports actions that are more related to block jobs, so moving it there would make sense to me. Kevin
Kevin Wolf <kwolf@redhat.com> writes: > Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben: >> Philippe Mathieu-Daudé <philmd@redhat.com> writes: >> >> > List this file in the proper section, so maintainers get >> > notified when it is modified. >> > >> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> > --- >> > Cc: Kevin Wolf <kwolf@redhat.com> >> > Cc: Max Reitz <mreitz@redhat.com> >> > Cc: qemu-block@nongnu.org >> > --- >> > MAINTAINERS | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index 903831e0a4..e269e9092c 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -1842,6 +1842,8 @@ S: Supported >> Block layer core >> M: Kevin Wolf <kwolf@redhat.com> >> M: Max Reitz <mreitz@redhat.com> >> L: qemu-block@nongnu.org >> S: Supported >> > F: block* >> > F: block/ >> > F: hw/block/ >> > +F: qapi/block.json >> > +F: qapi/block-core.json >> > F: include/block/ >> > F: qemu-img* >> > F: docs/interop/qemu-img.rst >> >> This is in addition to >> >> Block QAPI, monitor, command line >> M: Markus Armbruster <armbru@redhat.com> >> S: Supported >> F: blockdev.c >> F: block/qapi.c >> F: qapi/block*.json >> F: qapi/transaction.json >> T: git https://repo.or.cz/qemu/armbru.git block-next >> >> I'm not sure this section makes much sense anymore. > > This is probably for you to decide. > > Though the block-next branch from the T: line doesn't even exist any > more... I have the questionable habit to delete my -next branches when they're empty. >> Should qapi/transaction.json also be added to "Block layer core"? Or >> should it go into John's section "Block Jobs"? > > I think at the moment it only supports actions that are more related to > block jobs, so moving it there would make sense to me. Alright, what about this: diff --git a/MAINTAINERS b/MAINTAINERS index e72b5e5f69..43e821c901 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1842,6 +1842,8 @@ F: block* F: block/ F: hw/block/ F: include/block/ +F: qapi/block.json +F: qapi/block-core.json F: qemu-img* F: docs/interop/qemu-img.rst F: qemu-io* @@ -1887,16 +1889,8 @@ F: block/commit.c F: block/stream.c F: block/mirror.c F: qapi/job.json -T: git https://github.com/jnsnow/qemu.git jobs - -Block QAPI, monitor, command line -M: Markus Armbruster <armbru@redhat.com> -S: Supported -F: blockdev.c -F: block/qapi.c -F: qapi/block*.json F: qapi/transaction.json -T: git https://repo.or.cz/qemu/armbru.git block-next +T: git https://github.com/jnsnow/qemu.git jobs Dirty Bitmaps M: John Snow <jsnow@redhat.com>
On 2/7/20 5:07 PM, Markus Armbruster wrote: > Kevin Wolf <kwolf@redhat.com> writes: > >> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben: >>> Philippe Mathieu-Daudé <philmd@redhat.com> writes: >>> >>>> List this file in the proper section, so maintainers get >>>> notified when it is modified. >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>>> --- >>>> Cc: Kevin Wolf <kwolf@redhat.com> >>>> Cc: Max Reitz <mreitz@redhat.com> >>>> Cc: qemu-block@nongnu.org >>>> --- >>>> MAINTAINERS | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 903831e0a4..e269e9092c 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -1842,6 +1842,8 @@ S: Supported >>> Block layer core >>> M: Kevin Wolf <kwolf@redhat.com> >>> M: Max Reitz <mreitz@redhat.com> >>> L: qemu-block@nongnu.org >>> S: Supported >>>> F: block* >>>> F: block/ >>>> F: hw/block/ >>>> +F: qapi/block.json >>>> +F: qapi/block-core.json >>>> F: include/block/ >>>> F: qemu-img* >>>> F: docs/interop/qemu-img.rst >>> >>> This is in addition to >>> >>> Block QAPI, monitor, command line >>> M: Markus Armbruster <armbru@redhat.com> >>> S: Supported >>> F: blockdev.c >>> F: block/qapi.c >>> F: qapi/block*.json >>> F: qapi/transaction.json >>> T: git https://repo.or.cz/qemu/armbru.git block-next >>> >>> I'm not sure this section makes much sense anymore. >> >> This is probably for you to decide. >> >> Though the block-next branch from the T: line doesn't even exist any >> more... > > I have the questionable habit to delete my -next branches when they're > empty. Having dangling -next branches pointing to something very previous is also questionable...
diff --git a/MAINTAINERS b/MAINTAINERS index 903831e0a4..e269e9092c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1842,6 +1842,8 @@ S: Supported F: block* F: block/ F: hw/block/ +F: qapi/block.json +F: qapi/block-core.json F: include/block/ F: qemu-img* F: docs/interop/qemu-img.rst
List this file in the proper section, so maintainers get notified when it is modified. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: qemu-block@nongnu.org --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)