| Message ID | 20200207113939.9247-4-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | testing/next (rcutorture and misc tweaks) | expand |
On 2/7/20 12:39 PM, Alex Bennée wrote: > This is pure code motion with no functional effect. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/rcutorture.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/tests/rcutorture.c b/tests/rcutorture.c > index e8b2169e7dd..256d24ed5ba 100644 > --- a/tests/rcutorture.c > +++ b/tests/rcutorture.c > @@ -65,8 +65,6 @@ > #include "qemu/rcu.h" > #include "qemu/thread.h" > > -long long n_reads = 0LL; > -long n_updates = 0L; > int nthreadsrunning; > > #define GOFLAG_INIT 0 > @@ -78,11 +76,20 @@ static volatile int goflag = GOFLAG_INIT; > #define RCU_READ_RUN 1000 > > #define NR_THREADS 100 > -static QemuMutex counts_mutex; > static QemuThread threads[NR_THREADS]; > static struct rcu_reader_data *data[NR_THREADS]; > static int n_threads; > > +/* > + * Statistical counts > + * > + * These are the sum of local counters at the end of a run. > + * Updates are protected by a mutex. > + */ > +static QemuMutex counts_mutex; > +long long n_reads = 0LL; > +long n_updates = 0L; > + > static void create_thread(void *(*func)(void *)) > { > if (n_threads >= NR_THREADS) { > @@ -230,8 +237,9 @@ struct rcu_stress { > struct rcu_stress rcu_stress_array[RCU_STRESS_PIPE_LEN] = { { 0 } }; > struct rcu_stress *rcu_stress_current; > int rcu_stress_idx; > - > int n_mberror; > + > +/* Updates protected by counts_mutex */ > long long rcu_stress_count[RCU_STRESS_PIPE_LEN + 1]; > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/tests/rcutorture.c b/tests/rcutorture.c index e8b2169e7dd..256d24ed5ba 100644 --- a/tests/rcutorture.c +++ b/tests/rcutorture.c @@ -65,8 +65,6 @@ #include "qemu/rcu.h" #include "qemu/thread.h" -long long n_reads = 0LL; -long n_updates = 0L; int nthreadsrunning; #define GOFLAG_INIT 0 @@ -78,11 +76,20 @@ static volatile int goflag = GOFLAG_INIT; #define RCU_READ_RUN 1000 #define NR_THREADS 100 -static QemuMutex counts_mutex; static QemuThread threads[NR_THREADS]; static struct rcu_reader_data *data[NR_THREADS]; static int n_threads; +/* + * Statistical counts + * + * These are the sum of local counters at the end of a run. + * Updates are protected by a mutex. + */ +static QemuMutex counts_mutex; +long long n_reads = 0LL; +long n_updates = 0L; + static void create_thread(void *(*func)(void *)) { if (n_threads >= NR_THREADS) { @@ -230,8 +237,9 @@ struct rcu_stress { struct rcu_stress rcu_stress_array[RCU_STRESS_PIPE_LEN] = { { 0 } }; struct rcu_stress *rcu_stress_current; int rcu_stress_idx; - int n_mberror; + +/* Updates protected by counts_mutex */ long long rcu_stress_count[RCU_STRESS_PIPE_LEN + 1];
This is pure code motion with no functional effect. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/rcutorture.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)