[v2] btrfs: log message when rw remount is attempted with unclean tree-log
diff mbox series

Message ID 20200207151955.6647-1-dsterba@suse.com
State New
Headers show
Series
  • [v2] btrfs: log message when rw remount is attempted with unclean tree-log
Related show

Commit Message

David Sterba Feb. 7, 2020, 3:19 p.m. UTC
A remount to a read-write filesystem is not safe when there's tree-log
to be replayed. Files that could be opened until now might be affected
by the changes in the tree-log.

A regular mount is needed to replay the log so the filesystem presents
the consistent view with the pending changes included.

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: David Sterba <dsterba@suse.com>
---

* fix typo in fs_info parameter

 fs/btrfs/super.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Anand Jain Feb. 7, 2020, 4:02 p.m. UTC | #1
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Johannes Thumshirn Feb. 10, 2020, 10 a.m. UTC | #2
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Patch
diff mbox series

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 2bfccc40d0fb..5c16b4bcde9b 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1841,6 +1841,8 @@  static int btrfs_remount(struct super_block *sb, int *flags, char *data)
 		}
 
 		if (btrfs_super_log_root(fs_info->super_copy) != 0) {
+			btrfs_warn(fs_info,
+		"mount required to replay tree-log, cannot remount read-write");
 			ret = -EINVAL;
 			goto restore;
 		}