From patchwork Mon Feb 10 09:02:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 11372839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C9AD17EF for ; Mon, 10 Feb 2020 09:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7741821739 for ; Mon, 10 Feb 2020 09:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727540AbgBJJCZ (ORCPT ); Mon, 10 Feb 2020 04:02:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:60428 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbgBJJCZ (ORCPT ); Mon, 10 Feb 2020 04:02:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A6915AD3A; Mon, 10 Feb 2020 09:02:23 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Cc: Nikolay Borisov Subject: [PATCH] btrfs: Doc: Fix the wrong doc about `btrfs filesystem sync` Date: Mon, 10 Feb 2020 17:02:01 +0800 Message-Id: <20200210090201.29979-1-wqu@suse.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Since commit ecd4bb607f35 ("btrfs-progs: docs: enhance btrfs-filesystem manual page"), the man page of `btrfs filesystem` shows `sync` subcommand will wait for all existing orphan subvolumes to be dropped. That's not true, even at that commit, `btrfs fi sync` only calls BTRFS_IOC_SYNC ioctl, which is not that much different from vanilla sync. It doesn't wait for orphan subvolumes to be dropped from the very beginning. It's `btrfs subvolume sync` doing the wait work. Reported-by: Nikolay Borisov Fixes: ecd4bb607f35 ("btrfs-progs: docs: enhance btrfs-filesystem manual page") Signed-off-by: Qu Wenruo --- Documentation/btrfs-filesystem.asciidoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/btrfs-filesystem.asciidoc b/Documentation/btrfs-filesystem.asciidoc index 84efaa1a8f8f..3f62a3608cb1 100644 --- a/Documentation/btrfs-filesystem.asciidoc +++ b/Documentation/btrfs-filesystem.asciidoc @@ -253,9 +253,8 @@ show sizes in GiB, or GB with --si show sizes in TiB, or TB with --si *sync* :: -Force a sync of the filesystem at 'path'. This is done via a special ioctl and -will also trigger cleaning of deleted subvolumes. Besides that it's equivalent -to the `sync`(1) command. +Force a sync of the filesystem at 'path'. This should be the same as vanilla +'sync' command, but only for specified btrfs. *usage* [options] [...]:: Show detailed information about internal filesystem usage. This is supposed to