From patchwork Wed Feb 12 14:35:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11378631 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C619C921 for ; Wed, 12 Feb 2020 14:35:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8633521569 for ; Wed, 12 Feb 2020 14:35:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="J7K7FCFb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8633521569 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CA4C6B0458; Wed, 12 Feb 2020 09:35:25 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 97AD16B0459; Wed, 12 Feb 2020 09:35:25 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88F676B045A; Wed, 12 Feb 2020 09:35:25 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 6F4766B0458 for ; Wed, 12 Feb 2020 09:35:25 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E89E62C1F for ; Wed, 12 Feb 2020 14:35:24 +0000 (UTC) X-FDA: 76481722968.23.boy80_12222fc592405 X-Spam-Summary: 2,0,0,2ad867dc621512cf,d41d8cd98f00b204,cai@lca.pw,:akpm@linux-foundation.org:tj@kernel.org:elver@google.com:cl@linux.com:dennis@kernel.org::linux-kernel@vger.kernel.org:cai@lca.pw,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1345:1437:1534:1542:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2918:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:4321:5007:6261:6653:7903:10004:11026:11232:11473:11658:11914:12043:12296:12297:12438:12517:12519:12555:12895:13149:13161:13229:13230:14018:14093:14096:14104:14181:14394:14721:21080:21444:21451:21627:21990:30012:30054,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:45,LUA_SUMMARY:none X-HE-Tag: boy80_12222fc592405 X-Filterd-Recvd-Size: 4934 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 14:35:24 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id w15so2225354qkf.6 for ; Wed, 12 Feb 2020 06:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=5H+ytVXAlSIDd672XrGaeP1xTzQC9Kh/R6V2+KHWLTY=; b=J7K7FCFbZRwrJb3Q+P7eJKiwdE/0J6PYJFAy0oTD5YWB7lVxPIyz7mb4kGSYB7f5ai GOl1OBkENvmFQh+biNB5124mMtZGq6OE+jeGeKm+fLvo0ejxGAx6b5DQ1INbFoofJvBZ mutqVIJ8CxHsw8LZitpsUperrnkczXQJ7H1mtFP8vfsCbziI/6XDy8MDc6MDZCf877dJ 8duSgt1UXtpTqXbFnQig0ZAOHwyAGzILldc0Ery+QBC/B41ThIMSP99nOvrhiJBv8/fN 6IGnCdR0gVNydp1V1iCmUxJ2e7DAnvTv9tDD+ZXAXPZJUk1cW5SmKXQ9plauBwfTxNVL xndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5H+ytVXAlSIDd672XrGaeP1xTzQC9Kh/R6V2+KHWLTY=; b=mCQJHb+rFfZ4soqrQLXnEUArM13Neesm7gBBgMeUeVp2hCDydDlbPPdzdLMsQRSxlH cMAPpcXuKThyWFT4Ay/w10HpwMerZ3X+nt/Dk38aoiguGNS+lP421gWFGGYqi4q+g78M bIXAP8xnxCJnkHbSOOF7c0KPJ7UVvy2XS3IZj75Yu0gmasMttRcWyC1w3vV/G+vNkRXw 3hx9jLXDwm77Co0EpAyw5qjn5/fv/ui9RzyECIF61g1v/ysO39FKyRztlLpI3cjmZQpa w8f8N4NiZ9d4y8yl7UAuoNpy38tjJCCG3/SmpCWdIfyUtdrHR2iwRg5uj0cKmPeIyeDF KDRg== X-Gm-Message-State: APjAAAU7cNjMjbP214OMGPzdvZRE4MIeedYRdZEMOXOLiF08NIrwuVWg SNwpua6+TKGS62IlddxoUfeeFw== X-Google-Smtp-Source: APXvYqyEa1H60nZBFw4XsuMsuH61cc7gjm3HhNPri45OkYhkSKhHVSiCuhjTDa72DZ4gZLHmtjTFDA== X-Received: by 2002:ae9:edc4:: with SMTP id c187mr2983448qkg.34.1581518123593; Wed, 12 Feb 2020 06:35:23 -0800 (PST) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id v10sm245191qtp.22.2020.02.12.06.35.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2020 06:35:21 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: tj@kernel.org, elver@google.com, cl@linux.com, dennis@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next v2] mm/util: annotate an data race at vm_committed_as Date: Wed, 12 Feb 2020 09:35:09 -0500 Message-Id: <1581518109-21180-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000640, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "vm_committed_as.count" could be accessed concurrently as reported by KCSAN, read to 0xffffffff923164f8 of 8 bytes by task 1268 on cpu 38: __vm_enough_memory+0x43/0x280 mm/util.c:801 mmap_region+0x1b2/0xb90 mm/mmap.c:1726 do_mmap+0x45c/0x700 vm_mmap_pgoff+0xc0/0x130 vm_mmap+0x71/0x90 elf_map+0xa1/0x1b0 load_elf_binary+0x9de/0x2180 search_binary_handler+0xd8/0x2b0 __do_execve_file+0xb61/0x1080 __x64_sys_execve+0x5f/0x70 do_syscall_64+0x91/0xb47 entry_SYSCALL_64_after_hwframe+0x49/0xbe write to 0xffffffff923164f8 of 8 bytes by task 1265 on cpu 41: percpu_counter_add_batch+0x83/0xd0 lib/percpu_counter.c:91 exit_mmap+0x178/0x220 include/linux/mman.h:68 mmput+0x10e/0x270 flush_old_exec+0x572/0xfe0 load_elf_binary+0x467/0x2180 search_binary_handler+0xd8/0x2b0 __do_execve_file+0xb61/0x1080 __x64_sys_execve+0x5f/0x70 do_syscall_64+0x91/0xb47 entry_SYSCALL_64_after_hwframe+0x49/0xbe The warning is almost impossible to trigger according to the commit 82f71ae4a2b8 ("mm: catch memory commitment underflow") but leave it for now to catch any possible unbalanced vm_unacct_memory() in the future. Since only the read is operating as lockless, mark it as an intentional data race using the data_race() macro to avoid modifying percpu_counter_read() and still catch unintended races elsewhere. Acked-by: Christoph Lameter Acked-by: Dennis Zhou Signed-off-by: Qian Cai --- v2: add some code comments. mm/util.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/util.c b/mm/util.c index 988d11e6c17c..cc89e2404e19 100644 --- a/mm/util.c +++ b/mm/util.c @@ -798,8 +798,12 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) { long allowed; - VM_WARN_ONCE(percpu_counter_read(&vm_committed_as) < - -(s64)vm_committed_as_batch * num_online_cpus(), + /* + * A transient decrease in the value is unlikely, so no need + * READ_ONCE() for vm_committed_as.count. + */ + VM_WARN_ONCE(data_race(percpu_counter_read(&vm_committed_as) < + -(s64)vm_committed_as_batch * num_online_cpus()), "memory commitment underflow"); vm_acct_memory(pages);