diff mbox series

KVM: x86: enable -Werror

Message ID 1581535233-42127-1-git-send-email-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show
Series KVM: x86: enable -Werror | expand

Commit Message

Paolo Bonzini Feb. 12, 2020, 7:20 p.m. UTC
Avoid more embarrassing mistakes.  At least those that the compiler
can catch.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Vitaly Kuznetsov Feb. 20, 2020, 1:44 p.m. UTC | #1
Paolo Bonzini <pbonzini@redhat.com> writes:

> Avoid more embarrassing mistakes.  

"avoid more" != "make less" :-)

> At least those that the compiler can catch.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  arch/x86/kvm/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index b19ef421084d..4654e97a05cc 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
>  ccflags-y += -Iarch/x86/kvm
> +ccflags-y += -Werror
>  
>  KVM := ../../../virt/kvm

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Sean Christopherson Feb. 20, 2020, 7:39 p.m. UTC | #2
On Thu, Feb 20, 2020 at 02:44:00PM +0100, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > Avoid more embarrassing mistakes.  
> 
> "avoid more" != "make less" :-)

Ha!  "Fail the build so embarrassing mistakes are *really* emabarrassing".
Where there's a will, there's a way. :-)
diff mbox series

Patch

diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
index b19ef421084d..4654e97a05cc 100644
--- a/arch/x86/kvm/Makefile
+++ b/arch/x86/kvm/Makefile
@@ -1,6 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 
 ccflags-y += -Iarch/x86/kvm
+ccflags-y += -Werror
 
 KVM := ../../../virt/kvm