| Message ID | 1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 470a072e12200576788dc622d58894609feae2d7 |
| Headers | show |
| Series | [1/4] spi: spidev_test: Remove break after exit statement | expand |
On Thu, Feb 13, 2020 at 5:17 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote: > It is better to use perror() only if errno is not 0, it should use printf() > when errno is 0, otherwise there exists redudant ": Success". > > E.g. without this patch: > > $ ./spidev_test -p 1234 --input test.bin > only one of -p and --input may be selected: Success > Aborted (core dumped) > > With this patch: > > $ ./spidev_test -p 1234 --input test.bin > only one of -p and --input may be selected > Aborted (core dumped) > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c index 5866178..27967dd 100644 --- a/tools/spi/spidev_test.c +++ b/tools/spi/spidev_test.c @@ -13,6 +13,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <errno.h> #include <getopt.h> #include <fcntl.h> #include <time.h> @@ -26,7 +27,11 @@ static void pabort(const char *s) { - perror(s); + if (errno != 0) + perror(s); + else + printf("%s\n", s); + abort(); }
It is better to use perror() only if errno is not 0, it should use printf() when errno is 0, otherwise there exists redudant ": Success". E.g. without this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected: Success Aborted (core dumped) With this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected Aborted (core dumped) Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- tools/spi/spidev_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)