Message ID | 20200214204741.94112-11-jbi.octave@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | None | expand |
On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_lock()() > > warning: context imbalance in migrate_read_lock() - wrong count at exit > > The root cause is the missing annotation at migrate_read_lock() > Add the missing __acquires(&zspage->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Acked-by: Minchan Kim <minchan@kernel.org>
On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_lock()() > > warning: context imbalance in migrate_read_lock() - wrong count at exit > > The root cause is the missing annotation at migrate_read_lock() > Add the missing __acquires(&zspage->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Acked-by: Minchan Kim <minchan@kernel.org>
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 22d17ecfe7df..da70817b4ed8 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1833,7 +1833,7 @@ static void migrate_lock_init(struct zspage *zspage) rwlock_init(&zspage->lock); } -static void migrate_read_lock(struct zspage *zspage) +static void migrate_read_lock(struct zspage *zspage) __acquires(&zspage->lock) { read_lock(&zspage->lock); }
Sparse reports a warning at migrate_read_lock()() warning: context imbalance in migrate_read_lock() - wrong count at exit The root cause is the missing annotation at migrate_read_lock() Add the missing __acquires(&zspage->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)