Message ID | 20200214204741.94112-14-jbi.octave@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=bxHB=4C=kvack.org=owner-linux-mm@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 71B03139A for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 14 Feb 2020 20:49:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EB1224677 for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 14 Feb 2020 20:49:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R2gfH66r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EB1224677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BEDF6B0687; Fri, 14 Feb 2020 15:48:50 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 76D086B0688; Fri, 14 Feb 2020 15:48:50 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63A5F6B0689; Fri, 14 Feb 2020 15:48:50 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 4B21C6B0687 for <linux-mm@kvack.org>; Fri, 14 Feb 2020 15:48:50 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DB06B180AD81D for <linux-mm@kvack.org>; Fri, 14 Feb 2020 20:48:49 +0000 (UTC) X-FDA: 76489921578.20.pipe09_2ff3ba168491d X-Spam-Summary: 2,0,0,e890c8b06fcaa625,d41d8cd98f00b204,jbi.octave@gmail.com,:linux-kernel@vger.kernel.org:boqun.feng@gmail.com:jbi.octave@gmail.com:minchan@kernel.org:ngupta@vflare.org:sergey.senozhatsky.work@gmail.com:akpm@linux-foundation.org:,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1540:1711:1714:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3350:3865:3870:3871:4321:5007:6261:6653:7514:7875:9413:10004:11026:11473:11658:11914:12043:12297:12517:12519:12555:12679:12895:12986:13069:13161:13229:13311:13357:13894:14096:14181:14384:14394:14687:14721:21080:21433:21444:21451:21627:21666:21987:30054:30070,0,RBL:209.85.221.67:@gmail.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: pipe09_2ff3ba168491d X-Filterd-Recvd-Size: 3976 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf48.hostedemail.com (Postfix) with ESMTP for <linux-mm@kvack.org>; Fri, 14 Feb 2020 20:48:49 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id w15so12470082wru.4 for <linux-mm@kvack.org>; Fri, 14 Feb 2020 12:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DQaG6XnNE1ukMITaqxKDBRNvO+txpnsB9rpKWdE6tyA=; b=R2gfH66rLy/c7l4lV6E7iPng2NmRy1/Cko49qc9RwsAr0eg5uu/znhDnl5JV0VQMRT mwJ8hppTUrCZKIjlHdsJP0pPGsFZ9X9b8kH3PEi6gGqrHxjU8GbB1iSWbIZfqq9qszNA pBzSEn4SbWLL27AEEynn4PMo/mPQATGaVWZj/U2+t/3q5wLhCz3/8vmNbah4gcCavwLg MgA2QGqot4MhKTbsoZkYjSWqYUGsFmzI5WspfoYCp4Lc1zm7TZ+Ku+CdjQaQLX/zRJn+ qCkirrRAA161XEWWSGczBqi5nPmAna2neDZX5VnynaPuiOw8Q602JcSxErlrbMgpkkSv hBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DQaG6XnNE1ukMITaqxKDBRNvO+txpnsB9rpKWdE6tyA=; b=NQcQSZmyDRz1FUht7uSk0OX0ETyKKpaap4WekPMk+3Z2HkAHpACl3IK+2ls44vh3tz dIhHJugzJmF4Xc4V3Wm/vFchIUdVOxVrCZ4sETn7pwUI4OWqFFTFFj6KvMcxVqcy8Kgn 9P+WBN4ZudVyWPgoMOv9lCHQ/H532Yv+biZZtamDKQXuJmyd4chJHmnlP7K82KVp/OGM A3FYT+/G9wjNPuyko9glBUmrzKLH8Gyyp7vbT/vzr27LIsGRPYhftON4lPYLSRuCVBqt mfHsAuxCMmysUn7PxlU7SSKYfH8eP/KrGSyCQw1viqxYoWEejnSUG3c3XevEY2d6Za7Q 3+qw== X-Gm-Message-State: APjAAAVoBBcSzAPOyN7DyHKIYzqJX5ULvrRVFW9Yv67fVmknWqzlExCB FyJz+4Iekwtmn+lNy/yunQ== X-Google-Smtp-Source: APXvYqxZUKjy9Sf+P9bJmjwsrq+0zbt2cneuQHsL7RljUONH5y+df3SjkwhJDgbJpx/WFq03dPxPTw== X-Received: by 2002:adf:f302:: with SMTP id i2mr5811628wro.21.1581713328393; Fri, 14 Feb 2020 12:48:48 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:48 -0800 (PST) From: Jules Irenge <jbi.octave@gmail.com> To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge <jbi.octave@gmail.com>, Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org (open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR) Subject: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Date: Fri, 14 Feb 2020 20:47:24 +0000 Message-Id: <20200214204741.94112-14-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.006624, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
None
|
expand
|
On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote: > Sparse reports a warning at unpin_tag()() > > warning: context imbalance in unpin_tag() - unexpected unlock > > The root cause is the missing annotation at unpin_tag() > Add the missing __releases(bitlock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Acked-by: Minchan Kim <minchan@kernel.org>
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7bac76ae11b3..2aa2d524a343 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -896,7 +896,7 @@ static void pin_tag(unsigned long handle) __acquires(bitlock) bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle); } -static void unpin_tag(unsigned long handle) +static void unpin_tag(unsigned long handle) __releases(bitlock) { bit_spin_unlock(HANDLE_PIN_BIT, (unsigned long *)handle); }
Sparse reports a warning at unpin_tag()() warning: context imbalance in unpin_tag() - unexpected unlock The root cause is the missing annotation at unpin_tag() Add the missing __releases(bitlock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)