| Message ID | 20200214204741.94112-15-jbi.octave@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 2/14/20 3:47 PM, Jules Irenge wrote: > Sparse reports warning at xen_pte_lock() > > warning: context imbalance in xen_pte_lock() - wrong count at exit > > The root cause is the missing annotation at xen_pte_lock() > Add the missing __acquires(ptl) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> although I'd prefer this and the next patch to be merged into a single one.
Thanks for the feedback. I will send the merged version then if it s fine with you. Regards, Jules On Fri, 14 Feb 2020, Boris Ostrovsky wrote: > > > On 2/14/20 3:47 PM, Jules Irenge wrote: > > Sparse reports warning at xen_pte_lock() > > > > warning: context imbalance in xen_pte_lock() - wrong count at exit > > > > The root cause is the missing annotation at xen_pte_lock() > > Add the missing __acquires(ptl) annotation > > > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > although I'd prefer this and the next patch to be merged into a single one. > > >
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index bbba8b17829a..352f0c80cfcf 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -695,6 +695,7 @@ static int xen_pgd_walk(struct mm_struct *mm, /* If we're using split pte locks, then take the page's lock and return a pointer to it. Otherwise return NULL. */ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm) + __acquires(ptl) { spinlock_t *ptl = NULL;
Sparse reports warning at xen_pte_lock() warning: context imbalance in xen_pte_lock() - wrong count at exit The root cause is the missing annotation at xen_pte_lock() Add the missing __acquires(ptl) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- arch/x86/xen/mmu_pv.c | 1 + 1 file changed, 1 insertion(+)