| Message ID | 20200216173446.1823-3-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Odroid N2 failes to boot using upstream kernel using microSD card | expand |
On Sun 16 Feb 2020 at 18:34, Anand Moon <linux.amoon@gmail.com> wrote: > As per schematics add missing VCCV5 power supply to VDDIO_C/TF_IO > regulator. Also add TF_3V3N_1V8_EN signal name to gpio pin. Why ? I don't see the connection with the cover letter here ... > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > index 353db3b32cc4..23eddff85fe5 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > @@ -66,11 +66,14 @@ tf_io: gpio-regulator-tf_io { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > > + /* TF_3V3N_1V8_EN */ This is not terribly useful ... same for the previous patch > gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; > gpios-states = <0>; > > states = <3300000 0>, > <1800000 1>; > + /* U16 RT9179GB */ > + vin-supply = <&vcc_5v>; That is not parsed and not even part of the gpio regulator binding documentation. It won't make any difference. > }; > > flash_1v8: regulator-flash_1v8 {
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts index 353db3b32cc4..23eddff85fe5 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts @@ -66,11 +66,14 @@ tf_io: gpio-regulator-tf_io { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; + /* TF_3V3N_1V8_EN */ gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; gpios-states = <0>; states = <3300000 0>, <1800000 1>; + /* U16 RT9179GB */ + vin-supply = <&vcc_5v>; }; flash_1v8: regulator-flash_1v8 {