arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on
diff mbox series

Message ID 20200216202101.2810-1-linux.amoon@gmail.com
State New
Headers show
Series
  • arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on
Related show

Commit Message

Anand Moon Feb. 16, 2020, 8:21 p.m. UTC
usb-pwr-en regulator is getting disable after booting, setting
regulator-alway-on help enable the regulator after booting.

[   31.766097] USB_PWR_EN: disabling

Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Patch generated on top of my earier patch.
[0] https://patchwork.kernel.org/patch/11384531/
[1] https://patchwork.kernel.org/patch/11384533/

Before
[root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
       USB_PWR_EN                 0    1      0 unknown  5000mV     0mA  5000mV  5000mV
After
[root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
       USB_PWR_EN                 1    1      0 unknown  5000mV     0mA  5000mV  5000mV
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Jerome Brunet Feb. 17, 2020, 7:38 a.m. UTC | #1
On Sun 16 Feb 2020 at 21:21, Anand Moon <linux.amoon@gmail.com> wrote:

> usb-pwr-en regulator is getting disable after booting, setting
> regulator-alway-on help enable the regulator after booting.

This explains what your patch does, not why it needs to be done.
Why does this regulator need be on at all time ? What device needs it
and cannot claim it properly ?

>
> [   31.766097] USB_PWR_EN: disabling
>
> Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Patch generated on top of my earier patch.
> [0] https://patchwork.kernel.org/patch/11384531/
> [1] https://patchwork.kernel.org/patch/11384533/
>
> Before
> [root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
>        USB_PWR_EN                 0    1      0 unknown  5000mV     0mA  5000mV  5000mV
> After
> [root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
>        USB_PWR_EN                 1    1      0 unknown  5000mV     0mA  5000mV  5000mV
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 23eddff85fe5..938a9e15adfc 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -177,6 +177,7 @@ usb_pwr_en: regulator-usb_pwr_en {
>  		regulator-min-microvolt = <5000000>;
>  		regulator-max-microvolt = <5000000>;
>  		vin-supply = <&vcc_5v>;
> +		regulator-always-on;
>  
>  		/* Connected to the microUSB port power enable */
>  		gpio = <&gpio GPIOH_6 GPIO_ACTIVE_HIGH>;
Anand Moon Feb. 17, 2020, 8:06 a.m. UTC | #2
Hi Jerome,

On Mon, 17 Feb 2020 at 13:08, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Sun 16 Feb 2020 at 21:21, Anand Moon <linux.amoon@gmail.com> wrote:
>
> > usb-pwr-en regulator is getting disable after booting, setting
> > regulator-alway-on help enable the regulator after booting.
>
> This explains what your patch does, not why it needs to be done.
> Why does this regulator need be on at all time ? What device needs it
> and cannot claim it properly ?
>

I missed this node is for micro usb, plz discard this patch.
I am relay sorry for this, sorry for the noise.

-Anand

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 23eddff85fe5..938a9e15adfc 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -177,6 +177,7 @@  usb_pwr_en: regulator-usb_pwr_en {
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		vin-supply = <&vcc_5v>;
+		regulator-always-on;
 
 		/* Connected to the microUSB port power enable */
 		gpio = <&gpio GPIOH_6 GPIO_ACTIVE_HIGH>;