[v3,3/3] btrfs: relocation: Check cancel request after each extent found
diff mbox series

Message ID 20200217061654.65567-4-wqu@suse.com
State New
Headers show
  • btrfs: Make balance cancelling response faster
Related show

Commit Message

Qu Wenruo Feb. 17, 2020, 6:16 a.m. UTC
When relocating data block groups with tons of small extents, or
large metadata block groups, there can be over 200,000 extents.

We will iterate all extents of such block group in relocate_block_group(),
where iteration itself can be kinda time-consuming.

So when user want to cancel the balance, the extent iteration loop can
be another target.

This patch will add the cancelling check in the extent iteration loop of
relocate_block_group() to make balance cancelling faster.

Signed-off-by: Qu Wenruo <wqu@suse.com>
 fs/btrfs/relocation.c | 4 ++++
 1 file changed, 4 insertions(+)


Johannes Thumshirn Feb. 17, 2020, 9:04 a.m. UTC | #1
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

diff mbox series

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index dc97fdd58c3d..67433ae476d6 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -4181,6 +4181,10 @@  static noinline_for_stack int relocate_block_group(struct reloc_control *rc)
+		if (should_cancel_balance(fs_info)) {
+			err = -ECANCELED;
+			break;
+		}
 	if (trans && progress && err == -ENOSPC) {
 		ret = btrfs_force_chunk_alloc(trans, rc->block_group->flags);