[v3,4/4] dt-bindings: mmc: mediatek: Add document for mt6779
diff mbox series

Message ID 1581922564-24914-5-git-send-email-chun-hung.wu@mediatek.com
State New
Headers show
Series
  • mmc: mediatek: add mmc cqhci support
Related show

Commit Message

Chun-Hung Wu Feb. 17, 2020, 6:56 a.m. UTC
Add compatible node for mt6779 mmc

Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
---
 Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Feb. 19, 2020, 3:02 a.m. UTC | #1
On Mon, 17 Feb 2020 14:56:04 +0800, Chun-Hung Wu wrote:
> Add compatible node for mt6779 mmc
> 
> Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Matthias Brugger Feb. 20, 2020, 10:06 p.m. UTC | #2
On 19/02/2020 04:02, Rob Herring wrote:
> On Mon, 17 Feb 2020 14:56:04 +0800, Chun-Hung Wu wrote:
>> Add compatible node for mt6779 mmc
>>
>> Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

With the commit from patch 3/4 the compatible should be:
"mediatek,mt6779-mmc", "mediatek,mt8183-mmc": for mmc host ip compatible with mt6779

Regards,
Matthias
Chun-Hung Wu March 9, 2020, 11:16 p.m. UTC | #3
On Thu, 2020-02-20 at 23:06 +0100, Matthias Brugger wrote:
> 
> On 19/02/2020 04:02, Rob Herring wrote:
> > On Mon, 17 Feb 2020 14:56:04 +0800, Chun-Hung Wu wrote:
> >> Add compatible node for mt6779 mmc
> >>
> >> Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
> >> ---
> >>  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> 
> With the commit from patch 3/4 the compatible should be:
> "mediatek,mt6779-mmc", "mediatek,mt8183-mmc": for mmc host ip compatible with mt6779
As I know mt8183 is mt6771 platform not mt6779.
mt6771 does not support CQHCI.
> 
> Regards,
> Matthias

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 8a532f4..0c9cf6a 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -12,6 +12,7 @@  Required properties:
 	"mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
 	"mediatek,mt8183-mmc": for mmc host ip compatible with mt8183
 	"mediatek,mt8516-mmc": for mmc host ip compatible with mt8516
+	"mediatek,mt6779-mmc": for mmc host ip compatible with mt6779
 	"mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
 	"mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
 	"mediatek,mt7622-mmc": for MT7622 SoC