| Message ID | 20200217094240.9927-4-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools/virtiofsd: Fix warning reported by Clang static code analyzer | expand |
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/fuse_lowlevel.o > tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read > error = -ERANGE; > ^ ~~~~~~~ > > Fixes: 2de121f01e > Reported-by: Clang Static Analyzer > Reviewed-by: Ján Tomko <jtomko@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Nice, this actually fixes 3db2876 Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > RFC because untested > --- > tools/virtiofsd/fuse_lowlevel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c > index 704c0369b2..2dd36ec03b 100644 > --- a/tools/virtiofsd/fuse_lowlevel.c > +++ b/tools/virtiofsd/fuse_lowlevel.c > @@ -192,7 +192,7 @@ int fuse_send_reply_iov_nofree(fuse_req_t req, int error, struct iovec *iov, > > if (error <= -1000 || error > 0) { > fuse_log(FUSE_LOG_ERR, "fuse: bad error value: %i\n", error); > - error = -ERANGE; > + out.error = -ERANGE; > } > > iov[0].iov_base = &out; > -- > 2.21.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 2/17/20 9:06 PM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: >> Fix warning reported by Clang static code analyzer: >> >> CC tools/virtiofsd/fuse_lowlevel.o >> tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read >> error = -ERANGE; >> ^ ~~~~~~~ >> >> Fixes: 2de121f01e >> Reported-by: Clang Static Analyzer >> Reviewed-by: Ján Tomko <jtomko@redhat.com> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Nice, this actually fixes 3db2876 Good catch, so this fix can be applied to QEMU (while patch #1 needs backport from upstream libfuse), right? > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Thanks. > >> --- >> RFC because untested >> --- >> tools/virtiofsd/fuse_lowlevel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c >> index 704c0369b2..2dd36ec03b 100644 >> --- a/tools/virtiofsd/fuse_lowlevel.c >> +++ b/tools/virtiofsd/fuse_lowlevel.c >> @@ -192,7 +192,7 @@ int fuse_send_reply_iov_nofree(fuse_req_t req, int error, struct iovec *iov, >> >> if (error <= -1000 || error > 0) { >> fuse_log(FUSE_LOG_ERR, "fuse: bad error value: %i\n", error); >> - error = -ERANGE; >> + out.error = -ERANGE; >> } >> >> iov[0].iov_base = &out; >> -- >> 2.21.1 >> > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > On 2/17/20 9:06 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > > > Fix warning reported by Clang static code analyzer: > > > > > > CC tools/virtiofsd/fuse_lowlevel.o > > > tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read > > > error = -ERANGE; > > > ^ ~~~~~~~ > > > > > > Fixes: 2de121f01e > > > Reported-by: Clang Static Analyzer > > > Reviewed-by: Ján Tomko <jtomko@redhat.com> > > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > > > Nice, this actually fixes 3db2876 > > Good catch, so this fix can be applied to QEMU (while patch #1 needs > backport from upstream libfuse), right? I'll take all 3 into QEMU, libfuse can take it asynchronously. Dave > > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Thanks. > > > > > > --- > > > RFC because untested > > > --- > > > tools/virtiofsd/fuse_lowlevel.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c > > > index 704c0369b2..2dd36ec03b 100644 > > > --- a/tools/virtiofsd/fuse_lowlevel.c > > > +++ b/tools/virtiofsd/fuse_lowlevel.c > > > @@ -192,7 +192,7 @@ int fuse_send_reply_iov_nofree(fuse_req_t req, int error, struct iovec *iov, > > > if (error <= -1000 || error > 0) { > > > fuse_log(FUSE_LOG_ERR, "fuse: bad error value: %i\n", error); > > > - error = -ERANGE; > > > + out.error = -ERANGE; > > > } > > > iov[0].iov_base = &out; > > > -- > > > 2.21.1 > > > > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c index 704c0369b2..2dd36ec03b 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -192,7 +192,7 @@ int fuse_send_reply_iov_nofree(fuse_req_t req, int error, struct iovec *iov, if (error <= -1000 || error > 0) { fuse_log(FUSE_LOG_ERR, "fuse: bad error value: %i\n", error); - error = -ERANGE; + out.error = -ERANGE; } iov[0].iov_base = &out;
Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/fuse_lowlevel.o tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read error = -ERANGE; ^ ~~~~~~~ Fixes: 2de121f01e Reported-by: Clang Static Analyzer Reviewed-by: Ján Tomko <jtomko@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- RFC because untested --- tools/virtiofsd/fuse_lowlevel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)