[v2,1/3] dt-bindings: m_can: Add Documentation for transceiver regulator
diff mbox series

Message ID 20200217142836.23702-2-faiz_abbas@ti.com
State New
Headers show
Series
  • Add Support for MCAN in AM654x-idk
Related show

Commit Message

Faiz Abbas Feb. 17, 2020, 2:28 p.m. UTC
Some CAN transceivers have a standby line that needs to be asserted
before they can be used. Model this GPIO lines as an optional
fixed-regulator node. Document bindings for the same.

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
 Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Feb. 19, 2020, 8:35 p.m. UTC | #1
On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
> Some CAN transceivers have a standby line that needs to be asserted
> before they can be used. Model this GPIO lines as an optional
> fixed-regulator node. Document bindings for the same.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>  1 file changed, 3 insertions(+)

This has moved to DT schema in my tree, so please adjust it and resend.

> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
> index ed614383af9c..f17e2a5207dc 100644
> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
> @@ -48,6 +48,9 @@ Optional Subnode:
>  			  that can be used for CAN/CAN-FD modes. See
>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>  			  for details.
> +
> +- xceiver-supply: Regulator that powers the CAN transceiver.

The supply for a transceiver should go in the transceiver node.

> +
>  Example:
>  SoC dtsi:
>  m_can1: can@20e8000 {
> -- 
> 2.19.2
>
Marc Kleine-Budde Feb. 21, 2020, 8:31 a.m. UTC | #2
On 2/21/20 9:31 AM, Faiz Abbas wrote:
> Hi Rob,
> 
> On 20/02/20 2:05 am, Rob Herring wrote:
>> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>>> Some CAN transceivers have a standby line that needs to be asserted
>>> before they can be used. Model this GPIO lines as an optional
>>> fixed-regulator node. Document bindings for the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>>  1 file changed, 3 insertions(+)
>>
>> This has moved to DT schema in my tree, so please adjust it and resend.
> 
> Ok.
>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> index ed614383af9c..f17e2a5207dc 100644
>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> @@ -48,6 +48,9 @@ Optional Subnode:
>>>  			  that can be used for CAN/CAN-FD modes. See
>>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>>  			  for details.
>>> +
>>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>>
>> The supply for a transceiver should go in the transceiver node.
>>
> 
> Marc, while I have you here, do you agree with this?

I'll look into the details later today.

Marc
Faiz Abbas Feb. 21, 2020, 8:31 a.m. UTC | #3
Hi Rob,

On 20/02/20 2:05 am, Rob Herring wrote:
> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>> Some CAN transceivers have a standby line that needs to be asserted
>> before they can be used. Model this GPIO lines as an optional
>> fixed-regulator node. Document bindings for the same.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> This has moved to DT schema in my tree, so please adjust it and resend.

Ok.
> 
>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>> index ed614383af9c..f17e2a5207dc 100644
>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>> @@ -48,6 +48,9 @@ Optional Subnode:
>>  			  that can be used for CAN/CAN-FD modes. See
>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>  			  for details.
>> +
>> +- xceiver-supply: Regulator that powers the CAN transceiver.
> 
> The supply for a transceiver should go in the transceiver node.
> 

Marc, while I have you here, do you agree with this?

Thanks,
Faiz
Faiz Abbas Feb. 26, 2020, 9:10 a.m. UTC | #4
Hi Marc,

On 21/02/20 2:01 pm, Marc Kleine-Budde wrote:
> On 2/21/20 9:31 AM, Faiz Abbas wrote:
>> Hi Rob,
>>
>> On 20/02/20 2:05 am, Rob Herring wrote:
>>> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>>>> Some CAN transceivers have a standby line that needs to be asserted
>>>> before they can be used. Model this GPIO lines as an optional
>>>> fixed-regulator node. Document bindings for the same.
>>>>
>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>
>>> This has moved to DT schema in my tree, so please adjust it and resend.
>>
>> Ok.
>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>> index ed614383af9c..f17e2a5207dc 100644
>>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>> @@ -48,6 +48,9 @@ Optional Subnode:
>>>>  			  that can be used for CAN/CAN-FD modes. See
>>>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>>>  			  for details.
>>>> +
>>>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>>>
>>> The supply for a transceiver should go in the transceiver node.
>>>
>>
>> Marc, while I have you here, do you agree with this?
> 
> I'll look into the details later today.
> 

Sure. Be sure to take another look at my attempt to use the transceiver
with a phy driver some time ago.

https://lore.kernel.org/patchwork/patch/1006238/

Thanks,
Faiz
Faiz Abbas March 2, 2020, 8:16 a.m. UTC | #5
Marc,

On 26/02/20 2:40 pm, Faiz Abbas wrote:
> Hi Marc,
> 
> On 21/02/20 2:01 pm, Marc Kleine-Budde wrote:
>> On 2/21/20 9:31 AM, Faiz Abbas wrote:
>>> Hi Rob,
>>>
>>> On 20/02/20 2:05 am, Rob Herring wrote:
>>>> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>>>>> Some CAN transceivers have a standby line that needs to be asserted
>>>>> before they can be used. Model this GPIO lines as an optional
>>>>> fixed-regulator node. Document bindings for the same.
>>>>>
>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> This has moved to DT schema in my tree, so please adjust it and resend.
>>>
>>> Ok.
>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>> index ed614383af9c..f17e2a5207dc 100644
>>>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>> @@ -48,6 +48,9 @@ Optional Subnode:
>>>>>  			  that can be used for CAN/CAN-FD modes. See
>>>>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>>>>  			  for details.
>>>>> +
>>>>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>>>>
>>>> The supply for a transceiver should go in the transceiver node.
>>>>
>>>
>>> Marc, while I have you here, do you agree with this?
>>
>> I'll look into the details later today.
>>
> 
> Sure. Be sure to take another look at my attempt to use the transceiver
> with a phy driver some time ago.
> 
> https://lore.kernel.org/patchwork/patch/1006238/
> 

Do you have any comments?

Thanks,
Faiz
Faiz Abbas March 9, 2020, 2:30 p.m. UTC | #6
Hi Marc,

On 02/03/20 1:46 pm, Faiz Abbas wrote:
> Marc,
> 
> On 26/02/20 2:40 pm, Faiz Abbas wrote:
>> Hi Marc,
>>
>> On 21/02/20 2:01 pm, Marc Kleine-Budde wrote:
>>> On 2/21/20 9:31 AM, Faiz Abbas wrote:
>>>> Hi Rob,
>>>>
>>>> On 20/02/20 2:05 am, Rob Herring wrote:
>>>>> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>>>>>> Some CAN transceivers have a standby line that needs to be asserted
>>>>>> before they can be used. Model this GPIO lines as an optional
>>>>>> fixed-regulator node. Document bindings for the same.
>>>>>>
>>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>>>>> ---
>>>>>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> This has moved to DT schema in my tree, so please adjust it and resend.
>>>>
>>>> Ok.
>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>>> index ed614383af9c..f17e2a5207dc 100644
>>>>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>>>>> @@ -48,6 +48,9 @@ Optional Subnode:
>>>>>>  			  that can be used for CAN/CAN-FD modes. See
>>>>>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>>>>>  			  for details.
>>>>>> +
>>>>>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>>>>>
>>>>> The supply for a transceiver should go in the transceiver node.
>>>>>
>>>>
>>>> Marc, while I have you here, do you agree with this?
>>>
>>> I'll look into the details later today.
>>>
>>
>> Sure. Be sure to take another look at my attempt to use the transceiver
>> with a phy driver some time ago.
>>
>> https://lore.kernel.org/patchwork/patch/1006238/
>>
> 
> Do you have any comments?
> 

Gentle ping.

Thanks,
Faiz

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
index ed614383af9c..f17e2a5207dc 100644
--- a/Documentation/devicetree/bindings/net/can/m_can.txt
+++ b/Documentation/devicetree/bindings/net/can/m_can.txt
@@ -48,6 +48,9 @@  Optional Subnode:
 			  that can be used for CAN/CAN-FD modes. See
 			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
 			  for details.
+
+- xceiver-supply: Regulator that powers the CAN transceiver.
+
 Example:
 SoC dtsi:
 m_can1: can@20e8000 {