@@ -686,3 +686,46 @@ int sysfs_file_change_owner(struct kobject *kobj)
return error;
}
EXPORT_SYMBOL_GPL(sysfs_file_change_owner);
+
+/**
+ * sysfs_change_owner - change owner of the given object.
+ * @kobj: object.
+ *
+ * To change the ownership of a sysfs object, the caller must first change the
+ * uid/gid of the kobject and then call this function. Usually this will be
+ * taken care of by the relevant subsystem, e.g. moving a network device
+ * between network namespaces owned by different user namespaces will change
+ * the uid/gid of the kobject to the uid/gid of the root user in the user
+ * namespace. Calling this function afterwards will cause the sysfs object to
+ * reflect the new uid/gid.
+ */
+int sysfs_change_owner(struct kobject *kobj)
+{
+ int error;
+ const struct kobj_type *ktype;
+
+ if (!kobj->state_in_sysfs)
+ return -EINVAL;
+
+ error = sysfs_file_change_owner(kobj);
+ if (error)
+ return error;
+
+ ktype = get_ktype(kobj);
+ if (ktype) {
+ struct attribute **kattr;
+
+ for (kattr = ktype->default_attrs; kattr && *kattr; kattr++) {
+ error = sysfs_file_change_owner_by_name(kobj, (*kattr)->name);
+ if (error)
+ return error;
+ }
+
+ error = sysfs_groups_change_owner(kobj, ktype->default_groups);
+ if (error)
+ return error;
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(sysfs_change_owner);
@@ -312,6 +312,7 @@ static inline void sysfs_enable_ns(struct kernfs_node *kn)
int sysfs_file_change_owner(struct kobject *kobj);
int sysfs_file_change_owner_by_name(struct kobject *kobj, const char *name);
+int sysfs_change_owner(struct kobject *kobj);
int sysfs_link_change_owner(struct kobject *kobj, struct kobject *targ,
const char *name);
int sysfs_groups_change_owner(struct kobject *kobj,
@@ -549,6 +550,11 @@ static inline int sysfs_link_change_owner(struct kobject *kobj,
return 0;
}
+static inline int sysfs_change_owner(struct kobject *kobj)
+{
+ return 0;
+}
+
static inline int sysfs_groups_change_owner(struct kobject *kobj,
const struct attribute_group **groups)
{
Add a helper to change the owner of sysfs objects. The ownership of a sysfs object is determined based on the ownership of the corresponding kobject, i.e. only if the ownership of a kobject is changed will this function change the ownership of the corresponding sysfs entry. This function will be used to correctly account for kobject ownership changes, e.g. when moving network devices between network namespaces. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> --- /* v2 */ - Greg Kroah-Hartman <gregkh@linuxfoundation.org>: - Add comment how ownership of sysfs object is changed. --- fs/sysfs/file.c | 43 +++++++++++++++++++++++++++++++++++++++++++ include/linux/sysfs.h | 6 ++++++ 2 files changed, 49 insertions(+)