| Message ID | 20200218094402.26625-12-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | trivial: Detect and remove superfluous semicolons in C code | expand |
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > Fixes: 812d49f2a3e > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > Cc: Justin Terry (VM) <juterry@microsoft.com> > --- > target/i386/whpx-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c > index 3ed2aa1892..35601b8176 100644 > --- a/target/i386/whpx-all.c > +++ b/target/i386/whpx-all.c > @@ -511,7 +511,7 @@ static void whpx_get_registers(CPUState *cpu) > /* WHvX64RegisterPat - Skipped */ > > assert(whpx_register_names[idx] == WHvX64RegisterSysenterCs); > - env->sysenter_cs = vcxt.values[idx++].Reg64;; > + env->sysenter_cs = vcxt.values[idx++].Reg64; > assert(whpx_register_names[idx] == WHvX64RegisterSysenterEip); > env->sysenter_eip = vcxt.values[idx++].Reg64; > assert(whpx_register_names[idx] == WHvX64RegisterSysenterEsp); > -- > 2.21.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > Fixes: 812d49f2a3e > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
+Sunil Muthuswamy <sunilmut@microsoft.com> LGTM. Thanks! Reviewed-by: Justin Terry (VM) <juterry@microsoft.com> > -----Original Message----- > From: Dr. David Alan Gilbert <dgilbert@redhat.com> > Sent: Tuesday, February 18, 2020 2:00 AM > To: Philippe Mathieu-Daudé <philmd@redhat.com> > Cc: qemu-devel@nongnu.org; Max Reitz <mreitz@redhat.com>; Kevin Wolf > <kwolf@redhat.com>; Thomas Huth <thuth@redhat.com>; Fam Zheng > <fam@euphon.net>; Eduardo Habkost <ehabkost@redhat.com>; Alex > Williamson <alex.williamson@redhat.com>; Marcel Apfelbaum > <marcel.apfelbaum@gmail.com>; Richard Henderson <rth@twiddle.net>; > Julia Suvorova <jusual@redhat.com>; Thomas Huth <huth@tuxfamily.org>; > Edgar E. Iglesias <edgar.iglesias@gmail.com>; Aarushi Mehta > <mehta.aaru20@gmail.com>; qemu-trivial@nongnu.org; Stefan Hajnoczi > <stefanha@redhat.com>; Alistair Francis <alistair@alistair23.me>; Gerd > Hoffmann <kraxel@redhat.com>; Luc Michel <luc.michel@greensocs.com>; > Laurent Vivier <lvivier@redhat.com>; Juan Quintela > <quintela@redhat.com>; Michael Tokarev <mjt@tls.msk.ru>; Laurent Vivier > <laurent@vivier.eu>; Paolo Bonzini <pbonzini@redhat.com>; Yuval Shaia > <yuval.shaia.ml@gmail.com>; qemu-arm@nongnu.org; Peter Maydell > <peter.maydell@linaro.org>; qemu-block@nongnu.org; Justin Terry (SF) > <juterry@microsoft.com> > Subject: [EXTERNAL] Re: [PATCH RESEND 11/13] target/i386/whpx: Remove > superfluous semicolon > > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > > Fixes: 812d49f2a3e > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > > --- > > Cc: Justin Terry (VM) <juterry@microsoft.com> > > --- > > target/i386/whpx-all.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index > > 3ed2aa1892..35601b8176 100644 > > --- a/target/i386/whpx-all.c > > +++ b/target/i386/whpx-all.c > > @@ -511,7 +511,7 @@ static void whpx_get_registers(CPUState *cpu) > > /* WHvX64RegisterPat - Skipped */ > > > > assert(whpx_register_names[idx] == WHvX64RegisterSysenterCs); > > - env->sysenter_cs = vcxt.values[idx++].Reg64;; > > + env->sysenter_cs = vcxt.values[idx++].Reg64; > > assert(whpx_register_names[idx] == WHvX64RegisterSysenterEip); > > env->sysenter_eip = vcxt.values[idx++].Reg64; > > assert(whpx_register_names[idx] == WHvX64RegisterSysenterEsp); > > -- > > 2.21.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 3ed2aa1892..35601b8176 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -511,7 +511,7 @@ static void whpx_get_registers(CPUState *cpu) /* WHvX64RegisterPat - Skipped */ assert(whpx_register_names[idx] == WHvX64RegisterSysenterCs); - env->sysenter_cs = vcxt.values[idx++].Reg64;; + env->sysenter_cs = vcxt.values[idx++].Reg64; assert(whpx_register_names[idx] == WHvX64RegisterSysenterEip); env->sysenter_eip = vcxt.values[idx++].Reg64; assert(whpx_register_names[idx] == WHvX64RegisterSysenterEsp);
Fixes: 812d49f2a3e Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Justin Terry (VM) <juterry@microsoft.com> --- target/i386/whpx-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)